Issue 117783004: rebaseline_server: write JSON files using Unix line endings, even on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 117783004: rebaseline_server: write JSON files using Unix line endings, even on Windows (Closed)

Created:
7 years ago by epoger1 (DO NOT USE)

Modified:
7 years ago

Reviewers:
epoger, bsalomon

CC:
skia-review_googlegroups.com, rmistry

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

rebaseline_server: write JSON files using Unix line endings, even on Windows (SkipBuildbotRuns) BUG=skia:1815 NOTRY=True NOTREECHECKS=True Committed: http://code.google.com/p/skia/source/detail?r=12739

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	gm/gm_json.py	View		2 chunks	+8 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

epoger

Ready for review at patchset 1. I tested it manually on Windows, seems to work ...

7 years ago (2013-12-18 03:16:07 UTC) #1

bsalomon

On 2013/12/18 03:16:07, epoger wrote: > Ready for review at patchset 1. > > I ...

7 years ago (2013-12-18 15:02:23 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@gmail.com/117783004/1

7 years ago (2013-12-18 15:28:14 UTC) #3

Message was sent while issue was closed.

Change committed as 12739