Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11778074: Update bubble small shadow image assets. (Closed)

Created:
7 years, 11 months ago by xiyuan
Modified:
7 years, 11 months ago
Reviewers:
Finnur, oshima
CC:
chromium-reviews, msw+watch_chromium.org, tfarina, Aaron Boodman, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, alicet1
Visibility:
Public.

Description

Update bubble small shadow image assets. Also - removed the temp work-around in disabled_extensions_view.cc. - pngcrushed the images in common/. BUG=165808 TEST=Verify hotdog menu bubble does not go beyond browser window. R=oshima@chromium.org,finnur@chromium.org TBR=msw@chromium.org,sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176104

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-35 lines, --31 lines) Patch
M chrome/browser/ui/views/extensions/disabled_extensions_view.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/resources/default_100_percent/common/notification_close.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/common/notification_close_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/common/notification_close_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/common/notifications_expand.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/common/notifications_expand_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/common/notifications_expand_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/common/window_bubble_shadow_small_bottom.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/common/window_bubble_shadow_small_bottom_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/common/window_bubble_shadow_small_bottom_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/common/window_bubble_shadow_small_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/common/window_bubble_shadow_small_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/common/window_bubble_shadow_small_top.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/common/window_bubble_shadow_small_top_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/common/window_bubble_shadow_small_top_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/common/window_bubble_shadow_spike_small_bottom.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/common/window_bubble_shadow_spike_small_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/common/window_bubble_shadow_spike_small_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/common/window_bubble_shadow_spike_small_top.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/common/notification_close.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/common/notification_close_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/common/notification_close_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/common/notifications_expand.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/common/notifications_expand_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/common/notifications_expand_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/common/window_bubble_shadow_small_bottom.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/common/window_bubble_shadow_small_bottom_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/common/window_bubble_shadow_small_bottom_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/common/window_bubble_shadow_small_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/common/window_bubble_shadow_small_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/common/window_bubble_shadow_small_top.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/common/window_bubble_shadow_small_top_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/common/window_bubble_shadow_small_top_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/common/window_bubble_shadow_spike_small_bottom.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/common/window_bubble_shadow_spike_small_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/common/window_bubble_shadow_spike_small_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/common/window_bubble_shadow_spike_small_top.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/views/bubble/bubble_border.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
xiyuan
oshima: the window bubble small shadow image asset files are updated from gdrive. Notification image ...
7 years, 11 months ago (2013-01-09 22:12:51 UTC) #1
Finnur
Excellent! LGTM. Thank you.
7 years, 11 months ago (2013-01-10 10:14:38 UTC) #2
oshima
7 years, 11 months ago (2013-01-10 15:39:09 UTC) #3 
ui/resources LGTM

Powered by Google App Engine
This is Rietveld 408576698