Add support for getting the 256x256 app icon on Windows.

base/win/resource_util.cc

Index: base/win/resource_util.cc
===================================================================
--- base/win/resource_util.cc	(revision 176351)
+++ base/win/resource_util.cc	(working copy)
@@ -7,8 +7,12 @@
 
 namespace base {
 namespace win {
-bool GetDataResourceFromModule(HMODULE module, int resource_id,
-                               void** data, size_t* length) {
+
+bool GetResourceFromModule(HMODULE module,

[sky, 2013/01/11 17:21:49]

Change the header to match, by that I mean one param per line.

[Alexei Svitkine (slow), 2013/01/11 17:41:18]

Done.

+                           int resource_id,
+                           LPCTSTR resource_type,
+                           void** data,
+                           size_t* length) {
   if (!module)
     return false;
 
@@ -18,7 +22,7 @@
   }
 
   HRSRC hres_info = FindResource(module, MAKEINTRESOURCE(resource_id),
-                                 L"BINDATA");
+                                 resource_type);
   if (NULL == hres_info)
     return false;
 
@@ -35,5 +39,13 @@
   *length = static_cast<size_t>(data_size);
   return true;
 }
+
+bool GetDataResourceFromModule(HMODULE module,
+                               int resource_id,
+                               void** data,
+                               size_t* length) {
+  return GetResourceFromModule(module, resource_id, L"BINDATA", data, length);
+}
+
 }  // namespace win
 }  // namespace base