Add support for getting the 256x256 app icon on Windows.

Add support for getting the 256x256 app icon on Windows as a SkBitmap.

Also, adds an icon (a copy of chrome/app/theme/chromium/chromium.ico) to ui_unittests.exe, which is needed by the tests for this new functionality.

The icon was landed here: https://codereview.chromium.org/11877018/

BUG=167277
TEST=New unit tests in icon_util_unittests.cc.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176700

[Alexei Svitkine (slow), 2013-01-11 16:28:12]

Hey Scott,

Can you review this CL too? It's another change to icon_util.cc.

Thanks!

[sky, 2013-01-11 17:21:49]

LGTM. You'll need a base reviewer.

https://codereview.chromium.org/11778073/diff/29001/base/win/resource_util.cc
File base/win/resource_util.cc (right):

https://codereview.chromium.org/11778073/diff/29001/base/win/resource_util.cc...
base/win/resource_util.cc:11: bool GetResourceFromModule(HMODULE module,
Change the header to match, by that I mean one param per line.

[Alexei Svitkine (slow), 2013-01-11 17:41:18]

brettw: Can you approve the base/ changes?

https://codereview.chromium.org/11778073/diff/29001/base/win/resource_util.cc
File base/win/resource_util.cc (right):

https://codereview.chromium.org/11778073/diff/29001/base/win/resource_util.cc...
base/win/resource_util.cc:11: bool GetResourceFromModule(HMODULE module,
On 2013/01/11 17:21:49, sky wrote:
> Change the header to match, by that I mean one param per line.

Done.

[Alexei Svitkine (slow), 2013-01-11 21:53:25]

brettw seems to be OOO
willchan: Can you approve the base/ changes here?

Thanks!

[Alexei Svitkine (slow), 2013-01-12 14:56:08]

willchan is apparently in Patagonia. Switching out for jar.

Jim, can you approve the base/ changes?

[jar (doing other things), 2013-01-12 15:59:53]

base LGTM

[Alexei Svitkine (slow), 2013-01-14 15:55:10]

I'm landing the icon file in a separate CL
(https://codereview.chromium.org/11877018/) so that this one can use the cq,
since the cq doesn't like non-text files.

[commit-bot: I haz the power, 2013-01-14 16:01:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/11778073/36002

[commit-bot: I haz the power, 2013-01-14 19:45:36]

Change committed as 176700