Issue 11778068: Revert 175827

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11778068: Revert 175827 (Closed)

Created:
7 years, 11 months ago by jamesr

Modified:
7 years, 11 months ago

Reviewers:
jamesr

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, cc-bugs_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 175827 > Make RenderWidget responsible for the composited view's lifetime > > Chromium side of https://bugs.webkit.org/show_bug.cgi?id=105071. > content::RenderWidget constructs a WebLayerTreeView when WebKit > asks it and then retains ownership. This has to be destroyed > before the WebWidget is closed since the WLTVClient is (currently) > a WebKit object. > > BUG=156175 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175303 > > Review URL: https://codereview.chromium.org/11575049 Broke interactive_ui_tests:ExtensionApiTest.NotificationsHasPermissionManifest on windows TBR=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175834

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+241 lines, -298 lines)			Patch
M	content/content_renderer.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/renderer/render_view_impl.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/renderer/render_widget.h	View	3 chunks	+0 lines, -9 lines	0 comments	Download
M	content/renderer/render_widget.cc	View	8 chunks	+9 lines, -55 lines	0 comments	Download
M	webkit/compositor_bindings/web_layer_tree_view_impl.h	View	2 chunks	+57 lines, -70 lines	0 comments	Download
M	webkit/compositor_bindings/web_layer_tree_view_impl.cc	View	2 chunks	+175 lines, -161 lines	0 comments	Download

Total messages: 1 (0 generated)