Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: runtime/vm/heap_profiler.h

Issue 11778028: Fix confusion over on-disk object id sizes during instance serialization. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address review comment Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/heap_profiler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/heap_profiler.h
diff --git a/runtime/vm/heap_profiler.h b/runtime/vm/heap_profiler.h
index 7295fde7dc12c6bfd2bddb4a8e8e3e43e497355d..273dd46e3525af638395b911c3d77f3b73e225fb 100644
--- a/runtime/vm/heap_profiler.h
+++ b/runtime/vm/heap_profiler.h
@@ -74,6 +74,8 @@ class HeapProfiler {
kLong = 11
};
+ static const int kObjectIdSize = sizeof(uint64_t); // NOLINT
+
HeapProfiler(Dart_FileWriteCallback callback, void* stream);
~HeapProfiler();
@@ -161,7 +163,7 @@ class HeapProfiler {
void Write64(uint64_t value);
// Appends an ID to the body.
- void WritePointer(const void* value);
+ void WriteObjectId(const void* value);
private:
// A tag value that describes the record format.
@@ -195,7 +197,7 @@ class HeapProfiler {
void Write64(uint64_t value);
// Appends an ID to the current heap dump record.
- void WritePointer(const void* value);
+ void WriteObjectId(const void* value);
private:
// The record instance that receives forwarded write calls.
« no previous file with comments | « no previous file | runtime/vm/heap_profiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698