Chromium Code Reviews Chromium Code Reviews
Issue
11778025:
Decouple loading of channel info and the rest of machine statistics. (Closed)
DescriptionDecouple loading of channel info and the rest of machine statistics.
Related CL: crrev.com/173507 - that CL calls StatisticsProvider::Init()
in PreEarlyInitialization stage to obtain channel info early. However
it also has a side-effect to load machine statistics early. After this CL
we start to observe that sometimes the crossystem tool hangs.
Ideally the tool hang should be root caused but it is timing sensitive
and also extremely rare.
The current CL makes StatisticsProvider::StartLoadingMachineStatistics()
a separate and explicit call, so that the crossystem tool can be invoked
later at PostBrowserStart stage. Hopefully by restoring the timing we
can eliminate the tool hang.
BUG=167671
TEST=CQ, manually verified that machine statistics is still available
under chrome://settings in the "bios_info" section.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175434
Patch Set 1 #
Total comments: 2
Patch Set 2 : Add more comments, DCHECK. #
Total comments: 2
Patch Set 3 : Another DCHECK. #Patch Set 4 : Rebase at 175372. #Patch Set 5 : Fix build error in unit tests - need to declare the mock virtual function. #
Messages
Total messages: 12 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||
