Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 11778024: Add prompt for updating remote URL to git-on-borg. (Closed)

Created:
7 years, 11 months ago by szager1
Modified:
7 years, 11 months ago
Reviewers:
Michael Moss, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools@master
Visibility:
Public.

Description

Add prompt for updating remote URL to git-on-borg. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175419

Patch Set 1 #

Patch Set 2 : Also update url to end with .git #

Patch Set 3 : Don't set EnableDelayedExpansion #

Total comments: 4

Patch Set 4 : nits scratched #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M update_depot_tools View 1 1 chunk +1 line, -1 line 0 comments Download
M update_depot_tools.bat View 1 2 3 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
szager1
7 years, 11 months ago (2013-01-07 19:13:31 UTC) #1
M-A Ruel
lgtm with nits to make it slightly shorter. https://codereview.chromium.org/11778024/diff/5001/update_depot_tools.bat File update_depot_tools.bat (right): https://codereview.chromium.org/11778024/diff/5001/update_depot_tools.bat#newcode41 update_depot_tools.bat:41: IF ...
7 years, 11 months ago (2013-01-07 19:18:11 UTC) #2
szager1
https://codereview.chromium.org/11778024/diff/5001/update_depot_tools.bat File update_depot_tools.bat (right): https://codereview.chromium.org/11778024/diff/5001/update_depot_tools.bat#newcode41 update_depot_tools.bat:41: IF "%%x" == "%GIT_URL%" ( On 2013/01/07 19:18:11, Marc-Antoine ...
7 years, 11 months ago (2013-01-07 19:24:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/11778024/3
7 years, 11 months ago (2013-01-07 19:26:03 UTC) #4
commit-bot: I haz the power
Failed to apply patch for depot_tools/update_depot_tools.bat: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 11 months ago (2013-01-07 19:26:04 UTC) #5
M-A Ruel
7 years, 11 months ago (2013-01-07 19:29:20 UTC) #6
On 2013/01/07 19:26:04, I haz the power (commit-bot) wrote:
> Failed to apply patch for depot_tools/update_depot_tools.bat:
> While running patch -p1 --forward --force --no-backup-if-mismatch;
>   patching file depot_tools/update_depot_tools.bat
>   Hunk #1 FAILED at 7.
>   Hunk #2 FAILED at 35.
>   2 out of 2 hunks FAILED -- saving rejects to file
> depot_tools/update_depot_tools.bat.rej

"patch" is craptastic. Just commit manually.

Powered by Google App Engine
This is Rietveld 408576698