net/http/http_network_transaction_spdy2_unittest.cc - Issue 11778016: net: Stop using base::WorkerPool from UploadFileElementReader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_network_transaction_spdy2_unittest.cc

Issue 11778016: net: Stop using base::WorkerPool from UploadFileElementReader (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix CF Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_network_transaction_spdy2_unittest.cc

diff --git a/net/http/http_network_transaction_spdy2_unittest.cc b/net/http/http_network_transaction_spdy2_unittest.cc

index 74cffd853af60db67b20f257357765f66aa18883..62d5b9d98902e0394577f321074ea7397979b115 100644

--- a/net/http/http_network_transaction_spdy2_unittest.cc

+++ b/net/http/http_network_transaction_spdy2_unittest.cc

@@ -6531,7 +6531,8 @@ TEST_F(HttpNetworkTransactionSpdy2Test, UploadFileSmallerThanLength) {

ScopedVector<UploadElementReader> element_readers;

element_readers.push_back(

- new UploadFileElementReader(temp_file_path, 0, kuint64max, base::Time()));

+ new UploadFileElementReader(base::MessageLoopProxy::current(),

+ temp_file_path, 0, kuint64max, base::Time()));

UploadDataStream upload_data_stream(&element_readers, 0);

HttpRequestInfo request;

@@ -6584,7 +6585,8 @@ TEST_F(HttpNetworkTransactionSpdy2Test, UploadUnreadableFile) {

ScopedVector<UploadElementReader> element_readers;

element_readers.push_back(

- new UploadFileElementReader(temp_file, 0, kuint64max, base::Time()));

+ new UploadFileElementReader(base::MessageLoopProxy::current(),

+ temp_file, 0, kuint64max, base::Time()));

UploadDataStream upload_data_stream(&element_readers, 0);

HttpRequestInfo request;

@@ -6640,7 +6642,8 @@ TEST_F(HttpNetworkTransactionSpdy2Test, UnreadableUploadFileAfterAuthRestart) {

ScopedVector<UploadElementReader> element_readers;

element_readers.push_back(

- new UploadFileElementReader(temp_file, 0, kuint64max, base::Time()));

+ new UploadFileElementReader(base::MessageLoopProxy::current(),

+ temp_file, 0, kuint64max, base::Time()));

UploadDataStream upload_data_stream(&element_readers, 0);

HttpRequestInfo request;