NaCl: Re-enable the test FileIO_TouchQuery

NaCl: Re-enable the test FileIO_TouchQuery

This undoes the change r139605.

The only reported failure of this test on Windows was the exit status
0xc000008f problem, which was a problem with all NaCl tests on 32-bit
Windows (not just this test) and has since been fixed.

BUG=130349
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3227
TEST=browser_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175223

[dmichael (off chromium), 2013-01-04 21:28:47]

lgtm

[Paweł Hajdan Jr., 2013-01-04 22:45:21]

If the original underlying issue is fixed, fine. :)

Otherwise, it's not the best idea to re-enable a test you know will be flaky.

[dmichael (off chromium), 2013-01-04 22:51:17]

Mark is working on the fix; but the issue affects all NaCl tests. This test
presumably just got unlucky.

On Fri, Jan 4, 2013 at 3:45 PM, <phajdan.jr@chromium.org> wrote:

> If the original underlying issue is fixed, fine. :)
>
> Otherwise, it's not the best idea to re-enable a test you know will be
> flaky.
>
>
https://codereview.chromium.**org/11778002/<https://codereview.chromium.org/1...
>

[Paweł Hajdan Jr., 2013-01-04 22:59:19]

NACK then. Please don't re-enable tests that are known to be flaky. Unless there
is going to be some huge delay with the fix, this is a pretty strong opinion.

Note that you may think this will increase your test coverage. I'm not so
convinced. When tests have a reputation of being flaky, they are just more
likely to get disabled again, or cause someone to waste more time.

[Mark Seaborn, 2013-01-04 23:02:48]

On 4 January 2013 14:45, <phajdan.jr@chromium.org> wrote:

> If the original underlying issue is fixed, fine. :)
>

Yes, it is fixed.  See
http://code.google.com/p/chromium/issues/detail?id=132359#c14

The fix (r10529) was rolled into Chromium here:
https://codereview.chromium.org/11747023/

Otherwise, it's not the best idea to re-enable a test you know will be
> flaky.
>

I know.

Mark

[Paweł Hajdan Jr., 2013-01-04 23:09:20]

Alright, LGTM. Cool! :)