Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 1177773002: Deprecating high-conflict accelerators (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Simplified the design, modified tests accordingly, made accelerators consumable by webcontents if n… Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 32e0f784b6d5f6c16dbbebbfac2519d75a9a358b..908dcabd8b211504fbf3ae64a94f96be8d3b8fa3 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -1403,6 +1403,8 @@ bool BrowserView::PreHandleKeyboardEvent(const NativeWebKeyboardEvent& event,
// What we have to do here is as follows:
// - If the |browser_| is for an app, do nothing.
+ // - On CrOS if |accelerator| is deprecated, we allow web contents to consume
+ // it if needed.
// - If the |browser_| is not for an app, and the |accelerator| is not
// associated with the browser (e.g. an Ash shortcut), process it.
// - If the |browser_| is not for an app, and the |accelerator| is associated
@@ -1418,6 +1420,14 @@ bool BrowserView::PreHandleKeyboardEvent(const NativeWebKeyboardEvent& event,
return false;
}
+#if defined(OS_CHROMEOS)
+ if (focus_manager->IsAcceleratorDeprecated(accelerator)) {
+ if (event.type == blink::WebInputEvent::RawKeyDown)
+ *is_keyboard_shortcut = true;
+ return false;
+ }
+#endif // defined(OS_CHROMEOS)
+
chrome::BrowserCommandController* controller = browser_->command_controller();
// Here we need to retrieve the command id (if any) associated to the

Powered by Google App Engine
This is Rietveld 408576698