ash/system/system_notifier.cc - Issue 1177773002: Deprecating high-conflict accelerators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/system_notifier.cc

Issue 1177773002: Deprecating high-conflict accelerators (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplified the design, modified tests accordingly, made accelerators consumable by webcontents if n… Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/system/system_notifier.cc

diff --git a/ash/system/system_notifier.cc b/ash/system/system_notifier.cc

index c762930ed7a342c5752ebb675d9ff35f750f230b..b6aa1668b7d6fcd47acd541d0c69109d080342ca 100644

--- a/ash/system/system_notifier.cc

+++ b/ash/system/system_notifier.cc

@@ -22,6 +22,7 @@ namespace {

// which can appear regardless of the situation, such like login screen or lock

// screen.

const char* kAlwaysShownSystemNotifierIds[] = {

+ kNotifierAcceleratorController,

kNotifierBattery,

kNotifierDisplay,

kNotifierDisplayError,

@@ -69,6 +70,7 @@ bool MatchSystemNotifierId(const message_center::NotifierId& notifier_id,

} // namespace

+const char kNotifierAcceleratorController[] = "ash.accelerator-controller";

const char kNotifierBattery[] = "ash.battery";

const char kNotifierBluetooth[] = "ash.bluetooth";

const char kNotifierDisplay[] = "ash.display";