ash/accelerators/focus_manager_factory.h - Issue 1177773002: Deprecating high-conflict accelerators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/accelerators/focus_manager_factory.h

Issue 1177773002: Deprecating high-conflict accelerators (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplified the design, modified tests accordingly, made accelerators consumable by webcontents if n… Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/accelerators/focus_manager_factory.h

diff --git a/ash/accelerators/focus_manager_factory.h b/ash/accelerators/focus_manager_factory.h

index fc14151853dae300eb012e15d06e3dff3bc92b54..8ff6b96c4dccd7d14e3a7c19c52ea80e68761145 100644

--- a/ash/accelerators/focus_manager_factory.h

+++ b/ash/accelerators/focus_manager_factory.h

@@ -31,6 +31,8 @@ class AshFocusManagerFactory : public views::FocusManagerFactory {

bool ProcessAccelerator(const ui::Accelerator& accelerator) override;

ui::AcceleratorTarget* GetCurrentTargetForAccelerator(

const ui::Accelerator& accelerator) const override;

+ bool IsAcceleratorDeprecated(

+ const ui::Accelerator& accelerator) const override;

};

DISALLOW_COPY_AND_ASSIGN(AshFocusManagerFactory);