Deprecating high-conflict accelerators

chrome/browser/ui/views/accelerator_table.cc

Index: chrome/browser/ui/views/accelerator_table.cc
diff --git a/chrome/browser/ui/views/accelerator_table.cc b/chrome/browser/ui/views/accelerator_table.cc
index 1c022bd324e921590108112936ce87c0c03bd3bb..27d9abc9deba83fd8a70ac474d53d157ef2bf930 100644
--- a/chrome/browser/ui/views/accelerator_table.cc
+++ b/chrome/browser/ui/views/accelerator_table.cc
@@ -135,7 +135,6 @@ const AcceleratorMapping kAcceleratorMap[] = {
   { ui::VKEY_F6, ui::EF_SHIFT_DOWN, IDC_FOCUS_PREVIOUS_PANE },
   { ui::VKEY_F10, ui::EF_NONE, IDC_FOCUS_MENU_BAR },
   { ui::VKEY_F11, ui::EF_NONE, IDC_FULLSCREEN },
-  { ui::VKEY_ESCAPE, ui::EF_SHIFT_DOWN, IDC_TASK_MANAGER },
 
   // Platform-specific key maps.
 #if defined(OS_LINUX)
@@ -159,6 +158,7 @@ const AcceleratorMapping kAcceleratorMap[] = {
   { ui::VKEY_P, ui::EF_CONTROL_DOWN | ui::EF_ALT_DOWN,
     IDC_TOUCH_HUD_PROJECTION_TOGGLE },
 #else  // OS_CHROMEOS
+  { ui::VKEY_ESCAPE, ui::EF_SHIFT_DOWN, IDC_TASK_MANAGER },

[oshima, 2015/06/16 05:54:17]

I believe this will make it impossible for web pages to steal shift+esc.
Is it intentional?

[afakhry, 2015/06/16 22:30:33]

This is intentional. Having this accelerator on ChromeOS will create an issue
that Shift+Esc will be handled by BrowserView whenever the browser window is
shown. This will skip our newly introduced deprecated accelerator handling and
notification, we don't want that. On ChromeOS, there's no need to have two
places handling the same accelerator, so moving it only for non-chromeos
systems.

[oshima, 2015/06/17 05:06:30]

But this will change the current behavior, which I don't think what we want.
Let's discuss this tomorrow.

   { ui::VKEY_DELETE, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN,
     IDC_CLEAR_BROWSING_DATA },
   { ui::VKEY_LMENU, ui::EF_NONE, IDC_FOCUS_MENU_BAR },