Deprecating high-conflict accelerators

ash/accelerators/accelerator_table_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <set>
 
 #include "base/basictypes.h"
 #include "ash/accelerators/accelerator_table.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 58 matching lines @@
 
 TEST(AcceleratorTableTest, CheckDuplicatedNonrepeatableActions) {
   std::set<AcceleratorAction> actions;
   for (size_t i = 0; i < kNonrepeatableActionsLength; ++i) {
     EXPECT_TRUE(actions.insert(kNonrepeatableActions[i]).second)
         << "Duplicated action: " << kNonrepeatableActions[i]
         << " at index: " << i;
   }
 }
 
+TEST(AcceleratorTableTest, CheckDeprecatedAccelerators) {
+  std::set<AcceleratorAction> deprecated_actions;
+  for (size_t i = 0; i < kDeprecatedAcceleratorsLength; ++i) {
+    // A deprecated action can never appear twice in the list.
+    AcceleratorAction deprecated_action =
+        kDeprecatedAccelerators[i].deprecated_accelerator.action;
+    EXPECT_TRUE(deprecated_actions.insert(deprecated_action).second)
+        << "Duplicated action: " << deprecated_action << " at index: " << i;
+
+    // The UMA histogram name must be of the format "Ash.Accelerators.*"
+    std::string uma_histogram(kDeprecatedAccelerators[i].uma_histogram_name);
+    EXPECT_TRUE(uma_histogram.find("Ash.Accelerators.") != std::string::npos);
+    EXPECT_TRUE(uma_histogram.find("Ash.Accelerators.") == 0);
+  }
+}
+
 }  // namespace ash