Deprecating high-conflict accelerators

ui/views/focus/focus_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_FOCUS_FOCUS_MANAGER_H_
 #define UI_VIEWS_FOCUS_FOCUS_MANAGER_H_
 
 #include <list>
 #include <map>
 
@@ skipping 241 matching lines @@
   void UnregisterAccelerators(ui::AcceleratorTarget* target);
 
   // Activate the target associated with the specified accelerator.
   // First, AcceleratorPressed handler of the most recently registered target
   // is called, and if that handler processes the event (i.e. returns true),
   // this method immediately returns. If not, we do the same thing on the next
   // target, and so on.
   // Returns true if an accelerator was activated.
   bool ProcessAccelerator(const ui::Accelerator& accelerator);
 
+  // Returns true if the given |accelerator| has been deprecated and hence can
+  // be consumed by web contents if needed.
+  bool IsAcceleratorDeprecated(const ui::Accelerator& accelerator) const;

[sky, 2015/06/18 15:25:18]

Feels wrong to put this logic in FocusManager when it doesn't care about
deprecated accelerators at all. Is there another place closer to where you the
logic is that this code could live in?

[afakhry, 2015/06/19 17:26:54]

Deprecated accelerators are in ash. The FocusManager already has a delegate
(implemented in ash as AshFocusManagerFactory::Delegate) so that it can Process
ash accelerators (in ProcessAccelerator()) and act as the connection between
views and ash.

What do you recommend?

+
   // Resets menu key state if |event| is not menu key release.
   // This is effective only on x11.
   void MaybeResetMenuKeyState(const ui::KeyEvent& key);
 
   // Called by a RootView when a view within its hierarchy is removed
   // from its parent. This will only be called by a RootView in a
   // hierarchy of Widgets that this FocusManager is attached to the
   // parent Widget of.
   void ViewRemoved(View* removed);
 
@@ skipping 94 matching lines @@
 
   // See description above getter.
   bool is_changing_focus_;
 
   DISALLOW_COPY_AND_ASSIGN(FocusManager);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_FOCUS_FOCUS_MANAGER_H_