Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(30)

Issue 1177763005: [SP] Add flag to explicitly disable slimming paint by default when running layout tests. (Closed)

Created:
4 years, 10 months ago by wkorman
Modified:
4 years, 10 months ago
Reviewers:
chrishtr, Xianzhu
CC:
blink-reviews, pdr., Xianzhu
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[SP] Add flag to explicitly disable slimming paint by default when running layout tests. Note this is a no-op until we submit http://crrev.com/1169193003 to add the notion of a '--disable-slimming-paint' flag. By submitting this first, we ensure that the current state of LayoutTest expectations will continue to pass after we flip the slimming paint default. BUG=497950 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196913

Patch Set 1 #

Patch Set 2 : Fix unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (9 generated)
wkorman
4 years, 10 months ago (2015-06-10 20:50:26 UTC) #2
chrishtr
lgtm
4 years, 10 months ago (2015-06-10 20:54:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177763005/1
4 years, 10 months ago (2015-06-10 20:54:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/58440)
4 years, 10 months ago (2015-06-10 21:12:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177763005/20001
4 years, 10 months ago (2015-06-10 21:27:14 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/66118)
4 years, 10 months ago (2015-06-11 01:10:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177763005/20001
4 years, 10 months ago (2015-06-11 02:18:39 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/66173)
4 years, 10 months ago (2015-06-11 03:19:24 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177763005/20001
4 years, 10 months ago (2015-06-11 04:38:04 UTC) #18
commit-bot: I haz the power
4 years, 10 months ago (2015-06-11 05:33:18 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196913

Powered by Google App Engine
This is Rietveld 408576698