GTTF: Fix problems with contents detected by debugallocation:

GTTF: Fix problems with contents detected by debugallocation:

- unitialized variables

Example:

[320:320:0108/121207:1124051475207:FATAL:browser_main_loop.cc(175)] Gtk: IA__gtk_widget_set_size_request: assertion `width >= -1' failed
	base::debug::StackTrace::StackTrace() [0xc57eac]
	logging::LogMessage::~LogMessage() [0xc77719]
	content::(anonymous namespace)::GLibLogHandler() [0x33f749c]
	<unknown> [0x7fe62ad7ffa1]
	<unknown> [0x7fe62ad801b2]
	content::Shell::SizeTo() [0x81f69c]
	content::Shell::PlatformResizeSubViews() [0x81f6cc]
	content::Shell::CreateShell() [0x81c3f2]
	content::Shell::CreateNewWindow() [0x81c6fa]
	content::WebKitTestController::PrepareForLayoutTest() [0x829e82]
	content::InProcessBrowserLayoutTest::RunLayoutTestInternal() [0x5790f7]
	content::InProcessBrowserLayoutTest::RunLayoutTest() [0x578d91]
	content::MediaLayoutTest_VideoLoopTest_Test::RunTestOnMainThread() [0x4d93ba]
	content::ContentBrowserTest::RunTestOnMainThreadLoop() [0x573ba2]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() [0x83e5ab]
	base::internal::RunnableAdapter<>::Run() [0x83eb7e]
	base::internal::InvokeHelper<>::MakeItSo() [0x83eb16]
	base::internal::Invoker<>::Run() [0x83eac3]
	base::Callback<>::Run() [0x459f2d]
	content::ShellBrowserMainParts::PreMainMessageLoopRun() [0x838a4e]
	content::BrowserMainLoop::CreateThreads() [0x33f846e]
	content::BrowserMainRunnerImpl::Initialize() [0x326bd64]
	content::BrowserMain() [0x326b96b]
	content::BrowserTestBase::SetUp() [0x83e536]
	content::ContentBrowserTest::SetUp() [0x573a15]

BUG=30715
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175608

[jam, 2013-01-08 18:00:55]

https://codereview.chromium.org/11777028/diff/1/content/browser/browser_plugi...
File content/browser/browser_plugin/browser_plugin_host_browsertest.cc (right):

https://codereview.chromium.org/11777028/diff/1/content/browser/browser_plugi...
content/browser/browser_plugin/browser_plugin_host_browsertest.cc:905: GURL url
= GURL("https://www.example.com/index.html");
please use an owner from content/browser/browser_plugin, ideally whoever wrote
this

https://codereview.chromium.org/11777028/diff/1/content/shell/shell_gtk.cc
File content/shell/shell_gtk.cc (right):

https://codereview.chromium.org/11777028/diff/1/content/shell/shell_gtk.cc#ne...
content/shell/shell_gtk.cc:217: SizeTo(1000, 600);
you should check this with whoever wrote the gtk version

[Paweł Hajdan Jr., 2013-01-08 19:03:49]

Elliot, could you take a look? This fixes unitialized variable access.

[Elliot Glaysher, 2013-01-08 19:22:11]

https://codereview.chromium.org/11777028/diff/7001/content/shell/shell_gtk.cc
File content/shell/shell_gtk.cc (right):

https://codereview.chromium.org/11777028/diff/7001/content/shell/shell_gtk.cc...
content/shell/shell_gtk.cc:217: SizeTo(1000, 600);
Could you initialize |content_{width,height}_| instead? We want explicit resize
commands to work.

[jochen (gone - plz use gerrit), 2013-01-08 19:38:29]

https://codereview.chromium.org/11777028/diff/7001/content/shell/shell_gtk.cc
File content/shell/shell_gtk.cc (right):

https://codereview.chromium.org/11777028/diff/7001/content/shell/shell_gtk.cc...
content/shell/shell_gtk.cc:217: SizeTo(1000, 600);
On 2013/01/08 19:22:11, Elliot Glaysher wrote:
> Could you initialize |content_{width,height}_| instead? We want explicit
resize
> commands to work.

Also, shell.cc defines kTestWindow{Height,Width} which differs from 1000x600

[Paweł Hajdan Jr., 2013-01-08 20:15:39]

PTAL

[jochen (gone - plz use gerrit), 2013-01-08 20:20:34]

https://codereview.chromium.org/11777028/diff/13001/content/shell/shell_gtk.cc
File content/shell/shell_gtk.cc (right):

https://codereview.chromium.org/11777028/diff/13001/content/shell/shell_gtk.c...
content/shell/shell_gtk.cc:104: if (headless_)
You should invoke SizeTo(width, height) here

[Elliot Glaysher, 2013-01-08 20:21:04]

On 2013/01/08 20:15:39, Paweł Hajdan Jr. wrote:
> PTAL

I will defer to jochen here, since he's more aware of the layout test stuff than
I am, but otherwise, lgtm for not touching gtk window size stuff.

[Paweł Hajdan Jr., 2013-01-08 21:28:26]

Jochen, PTAL. Thank you for helping me figure out the best way to do that
(because there are many that seem to work).

[jochen (gone - plz use gerrit), 2013-01-08 21:29:51]

lgtm