Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 11777019: Move switch kUseGpuInTests from chrome to content (Closed)

Created:
7 years, 11 months ago by ccameron
Modified:
7 years, 11 months ago
Reviewers:
nduca, piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Move switch kUseGpuInTests from chrome to content The switch kUseGpuInTests is used to inform tests that they are running on a GPU bot (instead of a bot which may not have a real GPU in it). The existing GPU tests which use this flag are chrome tests, so this flag had been happy living in chrome. There exist some content GPU tests that don't use this flag, but the GPU memory manager test is the first content test which uses this flag (it renders some very complicated scenes to stress GPU memory, and we shouldn't count on being able to run all of them on software raster). BUG=135525 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175633

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ccameron
This has been split off from the change in https://codereview.chromium.org/11667030/
7 years, 11 months ago (2013-01-07 19:58:35 UTC) #1
nduca
lgtm
7 years, 11 months ago (2013-01-07 22:19:30 UTC) #2
ccameron
Thanks! Adding piman to review content/ changes (removing joi -- that wasn't the most specific ...
7 years, 11 months ago (2013-01-07 23:24:27 UTC) #3
piman
lgtm
7 years, 11 months ago (2013-01-07 23:35:29 UTC) #4
ccameron
Thanks!!
7 years, 11 months ago (2013-01-07 23:37:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/11777019/1
7 years, 11 months ago (2013-01-07 23:46:45 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 00:28:21 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698