Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 11777015: Fix ActiveTab sample extension (extension version in manifest needs to be a string). (Closed)

Created:
7 years, 11 months ago by Finnur
Modified:
7 years, 11 months ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Fix ActiveTab sample extension (extension version in manifest needs to be a string). BUG=None TEST=The sample extension for activeTab should not fail to load unpacked. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175345

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/extensions/docs/templates/articles/activeTab.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Finnur
Found this while testing the activeTab extension.
7 years, 11 months ago (2013-01-07 13:47:08 UTC) #1
not at google - send to devlin
lgtm
7 years, 11 months ago (2013-01-07 16:10:36 UTC) #2
commit-bot: I haz the power
7 years, 11 months ago (2013-01-07 16:25:56 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698