Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(24)

Issue 1177673004: Implement ShadowRoot.delegatesFocus 3/4 (Slide focus on focus() method) (Closed)

Created:
4 years, 10 months ago by kochi
Modified:
4 years, 10 months ago
Reviewers:
hayato
CC:
blink-reviews, arv+blink, vivekg, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, vivekg_samsung, Inactive, rwlbuis
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Implement ShadowRoot.delegatesFocus 3/4 (Slide focus on focus() method) This Implements sliding focus from shadow host to inner element of its shadow root on focus(). When delegatesFocus is set to true for a shadow root and its host gets focus() from script, the shadow host delegates focus to its internal focusable element. This depends on previous CLs. https://codereview.chromium.org/1174893002/ https://codereview.chromium.org/1174933002/ Remaining CL: 4/4 Match CSS :focus for shadow host Design doc: https://docs.google.com/document/d/1k93Ez6yNSyWQDtGjdJJqTBPmljk9l2WS3JTe5OHHB50/edit BUG=496005 TEST=fast/dom/shadow/focus-method-with-delegatesFocus.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196927

Patch Set 1 #

Patch Set 2 : minor fix #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -0 lines) Patch
A LayoutTests/fast/dom/shadow/focus-method-with-delegatesFocus.html View 1 1 chunk +85 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/focus-method-with-delegatesFocus-expected.txt View 1 chunk +27 lines, -0 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 2 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177673004/20001
4 years, 10 months ago (2015-06-10 11:13:30 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/66025)
4 years, 10 months ago (2015-06-10 13:15:07 UTC) #4
kochi
PTAL
4 years, 10 months ago (2015-06-11 04:05:30 UTC) #6
hayato
lgtm
4 years, 10 months ago (2015-06-11 04:27:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177673004/40001
4 years, 10 months ago (2015-06-11 07:15:58 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2015-06-11 08:31:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196927

Powered by Google App Engine
This is Rietveld 408576698