Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(173)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1177653002: Revert "Don't add artifical 1 pixel width to empty tables" (Closed)

Created:
4 years, 10 months ago by aelias_OOO_until_Jul13
Modified:
4 years, 10 months ago
CC:
aboxhall, blink-reviews, blink-reviews-rendering, dmazzoni, eae+blinkwatch, jchaffraix+rendering, je_julie, leviw+renderwatch, nektarios, pdr+renderingwatchlist_chromium.org, robhogan (do not use), szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert "Don't add artifical 1 pixel width to empty tables" This reverts commit 4769f3e7e6851362a2220aa7b3608fd72d47fce5, with manually readded NeedsRebaseline entries. The patch caused mobile Google Maps directions UI to break. BUG=497073, 424338 TBR=mstensho Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196822

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -304 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +30 lines, -0 lines 0 comments Download
M LayoutTests/accessibility/table-detection.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/css2.1/20110323/abspos-containing-block-initial-004e-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/css2.1/20110323/abspos-containing-block-initial-004f-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/table/auto-100-percent-width-expected.png View Binary file 0 comments Download
M LayoutTests/fast/table/auto-100-percent-width-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
D LayoutTests/fast/table/empty-cells-spread.html View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/table/empty-cells-spread-2.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/table/empty-cells-spread-2-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/table/empty-cells-spread-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/table/fixed-widths-exceed-available.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/table/large-shrink-wrapped-width.html View 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/table/table-cell-split-expected.png View Binary file 0 comments Download
M LayoutTests/fast/table/table-cell-split-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/table/table-insert-before-non-anonymous-block-expected.png View Binary file 0 comments Download
M LayoutTests/fast/table/table-insert-before-non-anonymous-block-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/table/table-section-split-with-after-content-expected.png View Binary file 0 comments Download
M LayoutTests/fast/table/table-section-split-with-after-content-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/platform/linux/css2.1/20110323/margin-applies-to-015-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/block/positioning/negative-right-pos-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/css/acid2-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/linux/fast/css/acid2-pixel-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/linux/fast/css/percentage-non-integer-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/fast/css/percentage-non-integer-expected.txt View 2 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/platform/linux/fast/dynamic/insert-before-table-part-in-continuation-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/platform/linux/fast/repaint/table-cell-move-expected.txt View 1 chunk +9 lines, -9 lines 0 comments Download
M LayoutTests/platform/linux/fast/table/012-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/table/cell-absolute-child-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/platform/linux/fast/table/empty-cells-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/fast/table/empty-cells-expected.txt View 7 chunks +21 lines, -21 lines 0 comments Download
M LayoutTests/platform/linux/fast/table/prepend-in-anonymous-table-expected.txt View 6 chunks +78 lines, -78 lines 0 comments Download
M LayoutTests/platform/linux/http/tests/misc/acid2-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/linux/http/tests/misc/acid2-pixel-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug100334-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug1188-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug16012-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug16012-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug3037-1-expected.txt View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/platform/linux/tables/mozilla_expected_failures/other/empty_cells-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/tables/mozilla_expected_failures/other/empty_cells-expected.txt View 4 chunks +32 lines, -32 lines 0 comments Download
M LayoutTests/platform/linux/virtual/slimmingpaint/fast/block/positioning/negative-right-pos-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/virtual/slimmingpaint/fast/repaint/table-cell-move-expected.txt View 1 chunk +9 lines, -9 lines 0 comments Download
M LayoutTests/svg/custom/stf-container-with-intrinsic-ratio-svg.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/tables/mozilla/bugs/bug222336-expected.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/layout/TableLayoutAlgorithmAuto.h View 3 chunks +1 line, -5 lines 0 comments Download
M Source/core/layout/TableLayoutAlgorithmAuto.cpp View 7 chunks +9 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177653002/1
4 years, 10 months ago (2015-06-10 03:05:43 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2015-06-10 04:08:31 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196822

Powered by Google App Engine
This is Rietveld 408576698