Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1177633002: Revert of Add simple presubmit check to remoting. (Closed)

Created:
5 years, 6 months ago by anandc
Modified:
5 years, 6 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add simple presubmit check to remoting. (patchset #2 id:60001 of https://codereview.chromium.org/1166123004/) Reason for revert: Abandoning in favour of implementing a better longer-term solution. Original issue's description: > Print out a note, during change upload, on running Remoting browser-tests before commiting changes under $src/remoting. > > BUG= > > Committed: https://crrev.com/44de127d69cd00dfc636e2f8f2cdf42f0e85b7d4 > Cr-Commit-Position: refs/heads/master@{#333390} TBR=jamiewalch@chromium.org,kelvinp@chromium.org,sergeyu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/9eba0f6f9ba4ba130c32e90968d84cdb9f2300a4 Cr-Commit-Position: refs/heads/master@{#333620}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
D remoting/PRESUBMIT.py View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
anandc
Created Revert of Add simple presubmit check to remoting.
5 years, 6 months ago (2015-06-10 00:16:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177633002/1
5 years, 6 months ago (2015-06-10 00:17:37 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-06-10 00:17:40 UTC) #4
Jamie
lgtm
5 years, 6 months ago (2015-06-10 00:25:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177633002/1
5 years, 6 months ago (2015-06-10 00:31:58 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 00:44:15 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 00:45:17 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9eba0f6f9ba4ba130c32e90968d84cdb9f2300a4
Cr-Commit-Position: refs/heads/master@{#333620}

Powered by Google App Engine
This is Rietveld 408576698