Issue 117763003: Mojo: Beginnings of (local) data pipe tests + more refactoring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 117763003: Mojo: Beginnings of (local) data pipe tests + more refactoring. (Closed)

Created:
7 years ago by viettrungluu

Modified:
7 years ago

Reviewers:
sky

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Beginnings of (local) data pipe tests + more refactoring. Make the DataPipe methods not take |flags|, to make it more obvious that dealing with/validating |flags| is the responsibility of the caller. Also split ConsumerReadData into three methods (read/discard/query), which parallels what the implementation subclass already had. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241585

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+273 lines, -93 lines)			Patch
	mojo/public/system/core.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	mojo/system/data_pipe.h	View		4 chunks	+16 lines, -14 lines	0 comments	Download
	mojo/system/data_pipe.cc	View		3 chunks	+37 lines, -20 lines	0 comments	Download
	mojo/system/data_pipe_consumer_dispatcher.cc	View		2 chunks	+21 lines, -13 lines	0 comments	Download
	mojo/system/data_pipe_producer_dispatcher.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
	mojo/system/local_data_pipe.h	View		2 chunks	+16 lines, -16 lines	0 comments	Download
	mojo/system/local_data_pipe.cc	View	1 2	8 chunks	+20 lines, -22 lines	0 comments	Download
M	mojo/system/local_data_pipe_unittest.cc	View	1 2	2 chunks	+158 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

Grr, getting 500s for latest upload, but you can look at the unified diffs to ...

7 years ago (2013-12-18 01:13:10 UTC) #2

viettrungluu

7 years ago (2013-12-18 17:38:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r241585 (presubmit successful).

Expand Messages | Collapse Messages

Issue 117763003: Mojo: Beginnings of (local) data pipe tests + more refactoring. (Closed)

Description

Patch Set 1 #

Patch Set 2 : small fix #

Patch Set 3 : another small fix + more tests #

Messages