Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(55)

Issue 1177623006: Componentization: make InspectorTaskRunner::IgnoreInterruptsScope visible for WebDevToolsAgentImpl. (Closed)

Created:
4 years, 10 months ago by tasak
Modified:
4 years, 10 months ago
Reviewers:
haraken, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Componentization: make InspectorTaskRunner::IgnoreInterruptsScope visible for WebDevToolsAgentImpl. Neet to make the class visble to fix the following link errors: blink_web.WebDevToolsAgentImpl.obj : error LNK2019: unresolved external symbol "public: __cdecl blink::InspectorTaskRunner::IgnoreInterruptsScope::IgnoreInterruptsScope(class blink::InspectorTaskRunner *)" blink_web.WebDevToolsAgentImpl.obj : error LNK2019: unresolved external symbol "public: __cdecl blink::InspectorTaskRunner::IgnoreInterruptsScope::~IgnoreInterruptsScope(void)" BUG=358074 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196845

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/inspector/InspectorTaskRunner.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
tasak
Would you review this CL?
4 years, 10 months ago (2015-06-10 05:43:16 UTC) #2
haraken
LGTM
4 years, 10 months ago (2015-06-10 05:46:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177623006/1
4 years, 10 months ago (2015-06-10 07:02:23 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-10 07:46:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196845

Powered by Google App Engine
This is Rietveld 408576698