Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: Source/core/editing/StyledMarkupAccumulator.h

Issue 1177623005: Refactoring: Remove StyledMarkupAccumulator::m_convertBlocksToInlines (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: yosin's review (early return) Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/editing/StyledMarkupAccumulator.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
3 * Copyright (C) 2008, 2009, 2010, 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2008, 2009, 2010, 2011 Google Inc. All rights reserved.
4 * Copyright (C) 2011 Igalia S.L. 4 * Copyright (C) 2011 Igalia S.L.
5 * Copyright (C) 2011 Motorola Mobility. All rights reserved. 5 * Copyright (C) 2011 Motorola Mobility. All rights reserved.
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without 7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions 8 * modification, are permitted provided that the following conditions
9 * are met: 9 * are met:
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 28 matching lines...) Expand all
39 class Document; 39 class Document;
40 class StylePropertySet; 40 class StylePropertySet;
41 class Text; 41 class Text;
42 42
43 class StyledMarkupAccumulator final { 43 class StyledMarkupAccumulator final {
44 WTF_MAKE_NONCOPYABLE(StyledMarkupAccumulator); 44 WTF_MAKE_NONCOPYABLE(StyledMarkupAccumulator);
45 STACK_ALLOCATED(); 45 STACK_ALLOCATED();
46 public: 46 public:
47 enum RangeFullySelectsNode { DoesFullySelectNode, DoesNotFullySelectNode }; 47 enum RangeFullySelectsNode { DoesFullySelectNode, DoesNotFullySelectNode };
48 48
49 StyledMarkupAccumulator(EAbsoluteURLs, const TextOffset& start, const TextOf fset& end, const PassRefPtrWillBeRawPtr<Document>, EAnnotateForInterchange, Node *, ConvertBlocksToInlines); 49 StyledMarkupAccumulator(EAbsoluteURLs, const TextOffset& start, const TextOf fset& end, const PassRefPtrWillBeRawPtr<Document>, EAnnotateForInterchange, Node *);
50
51 bool convertBlocksToInlines() const { return m_convertBlocksToInlines == Con vertBlocksToInlines::Convert; }
52 50
53 void appendString(const String&); 51 void appendString(const String&);
54 void appendStartTag(Node&); 52 void appendStartTag(Node&);
55 void appendEndTag(const Element&); 53 void appendEndTag(const Element&);
56 54
57 // TODO(hajimehoshi): These functions are called from the serializer, but 55 // TODO(hajimehoshi): These functions are called from the serializer, but
58 // should not. 56 // should not.
59 Node* highestNodeToBeSerialized() { return m_highestNodeToBeSerialized.get() ; } 57 Node* highestNodeToBeSerialized() { return m_highestNodeToBeSerialized.get() ; }
60 void setHighestNodeToBeSerialized(Node* highestNodeToBeSerialized) { m_highe stNodeToBeSerialized = highestNodeToBeSerialized; } 58 void setHighestNodeToBeSerialized(Node* highestNodeToBeSerialized) { m_highe stNodeToBeSerialized = highestNodeToBeSerialized; }
61 void setWrappingStyle(PassRefPtrWillBeRawPtr<EditingStyle> wrappingStyle) { m_wrappingStyle = wrappingStyle; } 59 void setWrappingStyle(PassRefPtrWillBeRawPtr<EditingStyle> wrappingStyle) { m_wrappingStyle = wrappingStyle; }
62 60
63 void wrapWithNode(ContainerNode&, RangeFullySelectsNode = DoesFullySelectNod e);
64 void wrapWithStyleNode(StylePropertySet*); 61 void wrapWithStyleNode(StylePropertySet*);
65 String takeResults(); 62 String takeResults();
66 63
64 void pushMarkup(const String&);
65 void appendElement(StringBuilder&, Element&, bool addDisplayInline, RangeFul lySelectsNode);
66 void appendStartMarkup(StringBuilder&, Node&);
67
67 private: 68 private:
68 void appendText(StringBuilder&, Text&); 69 void appendText(StringBuilder&, Text&);
69 70
70 String renderedText(Text&); 71 String renderedText(Text&);
71 String stringValueForRange(const Text&); 72 String stringValueForRange(const Text&);
72 73
73 bool shouldApplyWrappingStyle(const Node&) const; 74 bool shouldApplyWrappingStyle(const Node&) const;
74 75
75 bool shouldAnnotate() const; 76 bool shouldAnnotate() const;
76 77
77 void appendElement(StringBuilder&, Element&); 78 void appendElement(StringBuilder&, Element&);
78 void appendElement(StringBuilder&, Element&, bool, RangeFullySelectsNode);
79 void appendStartMarkup(StringBuilder&, Node&);
80 void appendEndMarkup(StringBuilder&, const Element&); 79 void appendEndMarkup(StringBuilder&, const Element&);
81 80
82 MarkupFormatter m_formatter; 81 MarkupFormatter m_formatter;
83 const TextOffset m_start; 82 const TextOffset m_start;
84 const TextOffset m_end; 83 const TextOffset m_end;
85 const RefPtrWillBeMember<Document> m_document; 84 const RefPtrWillBeMember<Document> m_document;
86 const EAnnotateForInterchange m_shouldAnnotate; 85 const EAnnotateForInterchange m_shouldAnnotate;
87 const ConvertBlocksToInlines m_convertBlocksToInlines;
88 RawPtrWillBeMember<Node> m_highestNodeToBeSerialized; 86 RawPtrWillBeMember<Node> m_highestNodeToBeSerialized;
89 RefPtrWillBeMember<EditingStyle> m_wrappingStyle; 87 RefPtrWillBeMember<EditingStyle> m_wrappingStyle;
90 StringBuilder m_result; 88 StringBuilder m_result;
91 Vector<String> m_reversedPrecedingMarkup; 89 Vector<String> m_reversedPrecedingMarkup;
92 }; 90 };
93 91
94 } // namespace blink 92 } // namespace blink
95 93
96 #endif // StyledMarkupAccumulator_h 94 #endif // StyledMarkupAccumulator_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/editing/StyledMarkupAccumulator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698