Issue 1177623005: Refactoring: Remove StyledMarkupAccumulator::m_convertBlocksToInlines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1177623005: Refactoring: Remove StyledMarkupAccumulator::m_convertBlocksToInlines (Closed)

Created:
4 years, 10 months ago by hajimehoshi

Modified:
4 years, 10 months ago

Reviewers:
tkent, yosin_UTC9

CC:
blink-reviews, blink-reviews-style_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Refactoring: Remove StyledMarkupAccumulator::m_convertBlocksToInlines This CL removes StyledMarkupAccumulator::m_convertBlocksToInlines by moving StyledMarkupAccumulator::wrapWithNode to StyledMarkupSerializer. This CL is a split of crrev.com/1163673005 and I aim to remove enum StyledMarkupAccumulator::RangeFullySelectsNodes. BUG=n/a TEST=n/a; no behavior change Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196841

Patch Set 1 #

Patch Set 2 : yosin's review (early return) #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -26 lines)			Patch
M	Source/core/editing/StyledMarkupAccumulator.h	View		4 chunks	+5 lines, -7 lines	0 comments	Download
M	Source/core/editing/StyledMarkupAccumulator.cpp	View		3 chunks	+6 lines, -14 lines	0 comments	Download
M	Source/core/editing/StyledMarkupSerializer.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	Source/core/editing/StyledMarkupSerializer.cpp	View	1	5 chunks	+18 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177623005/20001

4 years, 10 months ago (2015-06-10 05:42:50 UTC) #5

commit-bot: I haz the power

4 years, 10 months ago (2015-06-10 07:05:35 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196841

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages