 Chromium Code Reviews
 Chromium Code Reviews Issue 11776040:
  Add Windows implementation for base/debug/crash_logging.h.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src
    
  
    Issue 11776040:
  Add Windows implementation for base/debug/crash_logging.h.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: chrome/chrome_exe.gypi | 
| diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi | 
| index fd95e837da6db3853807b51389be81936dfc86dc..9b1281ae7380bc7ee244174dd34e8d84ad5cc138 100644 | 
| --- a/chrome/chrome_exe.gypi | 
| +++ b/chrome/chrome_exe.gypi | 
| @@ -474,6 +474,8 @@ | 
| ], | 
| 'sources': [ | 
| 'app/chrome_exe.rc', | 
| + 'common/crash_keys.cc', | 
| + 'common/crash_keys.h', | 
| 
Nico
2013/01/24 18:01:14
Should these be in the sources section at the top
 | 
| '<(SHARED_INTERMEDIATE_DIR)/chrome_version/chrome_exe_version.rc', | 
| ], | 
| 'msvs_settings': { | 
| @@ -549,6 +551,7 @@ | 
| 'app/breakpad_win.cc', | 
| 'app/crash_analysis_win.cc', | 
| 'app/hard_error_handler_win.cc', | 
| + 'common/crash_keys.cc', | 
| 'nacl/nacl_exe_win_64.cc', | 
| '../content/app/startup_helper_win.cc', | 
| '../content/common/debug_flags.cc', # Needed for sandbox_policy.cc |