 Chromium Code Reviews
 Chromium Code Reviews Issue 11776040:
  Add Windows implementation for base/debug/crash_logging.h.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src
    
  
    Issue 11776040:
  Add Windows implementation for base/debug/crash_logging.h.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src| OLD | NEW | 
|---|---|
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be | 
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. | 
| 4 | 4 | 
| 5 { | 5 { | 
| 6 'targets': [ | 6 'targets': [ | 
| 7 { | 7 { | 
| 8 'target_name': 'chrome', | 8 'target_name': 'chrome', | 
| 9 'type': 'executable', | 9 'type': 'executable', | 
| 10 'mac_bundle': 1, | 10 'mac_bundle': 1, | 
| (...skipping 456 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 467 'installer_util', | 467 'installer_util', | 
| 468 'image_pre_reader', | 468 'image_pre_reader', | 
| 469 '../base/base.gyp:base', | 469 '../base/base.gyp:base', | 
| 470 '../breakpad/breakpad.gyp:breakpad_handler', | 470 '../breakpad/breakpad.gyp:breakpad_handler', | 
| 471 '../breakpad/breakpad.gyp:breakpad_sender', | 471 '../breakpad/breakpad.gyp:breakpad_sender', | 
| 472 '../sandbox/sandbox.gyp:sandbox', | 472 '../sandbox/sandbox.gyp:sandbox', | 
| 473 'app/policy/cloud_policy_codegen.gyp:policy', | 473 'app/policy/cloud_policy_codegen.gyp:policy', | 
| 474 ], | 474 ], | 
| 475 'sources': [ | 475 'sources': [ | 
| 476 'app/chrome_exe.rc', | 476 'app/chrome_exe.rc', | 
| 477 'common/crash_keys.cc', | |
| 478 'common/crash_keys.h', | |
| 
Nico
2013/01/24 18:01:14
Should these be in the sources section at the top
 | |
| 477 '<(SHARED_INTERMEDIATE_DIR)/chrome_version/chrome_exe_version.rc', | 479 '<(SHARED_INTERMEDIATE_DIR)/chrome_version/chrome_exe_version.rc', | 
| 478 ], | 480 ], | 
| 479 'msvs_settings': { | 481 'msvs_settings': { | 
| 480 'VCLinkerTool': { | 482 'VCLinkerTool': { | 
| 481 'ImportLibrary': '$(OutDir)\\lib\\chrome_exe.lib', | 483 'ImportLibrary': '$(OutDir)\\lib\\chrome_exe.lib', | 
| 482 'DelayLoadDLLs': [ | 484 'DelayLoadDLLs': [ | 
| 483 'dbghelp.dll', | 485 'dbghelp.dll', | 
| 484 'dwmapi.dll', | 486 'dwmapi.dll', | 
| 485 'uxtheme.dll', | 487 'uxtheme.dll', | 
| 486 'ole32.dll', | 488 'ole32.dll', | 
| (...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 542 ['disable_nacl!=1', { | 544 ['disable_nacl!=1', { | 
| 543 'targets': [ | 545 'targets': [ | 
| 544 { | 546 { | 
| 545 'target_name': 'chrome_nacl_win64', | 547 'target_name': 'chrome_nacl_win64', | 
| 546 'type': 'executable', | 548 'type': 'executable', | 
| 547 'product_name': 'nacl64', | 549 'product_name': 'nacl64', | 
| 548 'sources': [ | 550 'sources': [ | 
| 549 'app/breakpad_win.cc', | 551 'app/breakpad_win.cc', | 
| 550 'app/crash_analysis_win.cc', | 552 'app/crash_analysis_win.cc', | 
| 551 'app/hard_error_handler_win.cc', | 553 'app/hard_error_handler_win.cc', | 
| 554 'common/crash_keys.cc', | |
| 552 'nacl/nacl_exe_win_64.cc', | 555 'nacl/nacl_exe_win_64.cc', | 
| 553 '../content/app/startup_helper_win.cc', | 556 '../content/app/startup_helper_win.cc', | 
| 554 '../content/common/debug_flags.cc', # Needed for sandbox_policy .cc | 557 '../content/common/debug_flags.cc', # Needed for sandbox_policy .cc | 
| 555 '../content/common/sandbox_init_win.cc', | 558 '../content/common/sandbox_init_win.cc', | 
| 556 '../content/common/sandbox_policy.cc', | 559 '../content/common/sandbox_policy.cc', | 
| 557 '../content/public/common/content_switches.cc', | 560 '../content/public/common/content_switches.cc', | 
| 558 '<(SHARED_INTERMEDIATE_DIR)/chrome_version/nacl64_exe_version.rc ', | 561 '<(SHARED_INTERMEDIATE_DIR)/chrome_version/nacl64_exe_version.rc ', | 
| 559 ], | 562 ], | 
| 560 'dependencies': [ | 563 'dependencies': [ | 
| 561 'app/policy/cloud_policy_codegen.gyp:policy_win64', | 564 'app/policy/cloud_policy_codegen.gyp:policy_win64', | 
| (...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 599 'target_name': 'chrome_nacl_win64', | 602 'target_name': 'chrome_nacl_win64', | 
| 600 'type': 'none', | 603 'type': 'none', | 
| 601 'sources': [], | 604 'sources': [], | 
| 602 }, | 605 }, | 
| 603 ], | 606 ], | 
| 604 }], | 607 }], | 
| 605 ], | 608 ], | 
| 606 }], | 609 }], | 
| 607 ], | 610 ], | 
| 608 } | 611 } | 
| OLD | NEW |