Include all allocations in trivial dead-store elimination

pkg/compiler/lib/src/ssa/optimize.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 abstract class OptimizationPhase {
   String get name;
   void visitGraph(HGraph graph);
 }
@@ skipping 1124 matching lines @@
       if (use is HFieldSet) {
         // The use must be the receiver.  Even if the use is also the argument,
         // i.e.  a.x = a, the store is still dead if all other uses are dead.
         if (use.getDartReceiver(compiler) == instruction) return true;
       } else if (use is HFieldGet) {
         assert(use.getDartReceiver(compiler) == instruction);
         if (isDeadCode(use)) return true;
       }
       return false;
     }
-    return instruction is HForeignNew
+    return instruction.isAllocation
+        && instruction.isPure()
         && trivialDeadStoreReceivers.putIfAbsent(instruction,
             () => instruction.usedBy.every(isDeadUse));
   }
 
   bool isTrivialDeadStore(HInstruction instruction) {
     return instruction is HFieldSet
         && isTrivialDeadStoreReceiver(instruction.getDartReceiver(compiler));
   }
 
   bool isDeadCode(HInstruction instruction) {
     if (!instruction.usedBy.isEmpty) return false;
     if (isTrivialDeadStore(instruction)) return true;
     if (instruction.sideEffects.hasSideEffects()) return false;
-    if (instruction.canThrow()
-        && instruction.onlyThrowsNSM()
-        && hasFollowingThrowingNSM(instruction)) {
+    if (instruction.canThrow() &&
+        instruction.onlyThrowsNSM() &&
+        hasFollowingThrowingNSM(instruction)) {
       return true;
     }
     return !instruction.canThrow()
-           && instruction is !HParameterValue
-           && instruction is !HLocalSet;
+        && instruction is !HParameterValue
+        && instruction is !HLocalSet;
   }
 
   void visitGraph(HGraph graph) {
     analyzer = new SsaLiveBlockAnalyzer(graph, compiler, optimizer);
     analyzer.analyze();
     visitPostDominatorTree(graph);
     cleanPhis(graph);
   }
 
   void visitBasicBlock(HBasicBlock block) {
@@ skipping 1118 matching lines @@
 
     keyedValues.forEach((receiver, values) {
       result.keyedValues[receiver] =
           new Map<HInstruction, HInstruction>.from(values);
     });
 
     result.nonEscapingReceivers.addAll(nonEscapingReceivers);
     return result;
   }
 }