Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 11776020: Merge 138165 (Closed)

Created:
8 years, 2 months ago by hayato
Modified:
8 years, 2 months ago
Reviewers:
hayato
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 138165 > Expose WebKitShadowRoot constructor to DOMWindow. > https://bugs.webkit.org/show_bug.cgi?id=105385 > > Reviewed by Dimitri Glazkov. > > Source/WebCore: > > This is a follow-up patch for r137870. WebKitShadowRoot > constructor should be in DOMWindow, just like all of the other > not-callable-constructors like HTMLDivElement, etc. We need it > for instanceof tests and so on. > > Test: fast/dom/shadow/shadow-root-js-api.html > fast/js/global-constructors-expected.html > > * page/DOMWindow.idl: > > LayoutTests: > > * fast/dom/shadow/shadow-root-js-api-expected.txt: > * fast/dom/shadow/shadow-root-js-api.html: > * fast/js/global-constructors-expected.txt: > * platform/efl/fast/js/global-constructors-expected.txt: > * platform/gtk/fast/js/global-constructors-expected.txt: > TBR=hayato@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138925

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M LayoutTests/fast/dom/shadow/shadow-root-js-api.html View 1 chunk +7 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-root-js-api-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/fast/js/global-constructors-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/efl/fast/js/global-constructors-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/page/DOMWindow.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
hayato
8 years, 2 months ago (2013-01-07 06:43:20 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698