overscroll: Take a screenshot at more appropriate times.

content/renderer/render_view_impl.cc

Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 37d1011dc930132ba83deb303b2f85c65398c999..47c606f14d62df895d100fabe0f4ff6aaf9de84a 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -5447,6 +5447,10 @@ void RenderViewImpl::OnSwapOut(const ViewMsg_SwapOut_Params& params) {
     // Synchronously run the unload handler before sending the ACK.
     webview()->dispatchUnloadEvent();
 
+    // Mark the view as hidden, to make sure that it does not erase the paint
+    // contents.
+    SetHidden(true);

[Charlie Reis, 2013/01/09 00:49:23]

Interesting.  This looks similar to the setVisibilityState call below.  I wonder
if we should move that call up alongside this one, and whether both are needed
or if just moving that up here is sufficient.

[sadrul, 2013/01/09 17:44:19]

I moved the call to setVisibilityState up here.

SetHidden() and setVisibilityState() do different things, and both are called in
response to a WasHidden/WasShown message from the browser. I tried removing the
call to SetHidden, but that didn't work.

Do you think it might be necessary to call SetHidden(false) when the renderer
gets swapped back in, or does it always get a WasShown message when necessary?

+
     // Swap out and stop sending any IPC messages that are not ACKs.
     SetSwappedOut(true);