Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: content/browser/web_contents/navigation_controller_impl.h

Issue 11776010: overscroll: Take a screenshot at more appropriate times. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/web_contents/navigation_controller_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/navigation_controller_impl.h
diff --git a/content/browser/web_contents/navigation_controller_impl.h b/content/browser/web_contents/navigation_controller_impl.h
index 275ba2a4262a5dc5932e2719df600751aad47b69..41107c0ff10f64c3929cec83ed8acbdb26648b38 100644
--- a/content/browser/web_contents/navigation_controller_impl.h
+++ b/content/browser/web_contents/navigation_controller_impl.h
@@ -23,6 +23,7 @@ class PlatformBitmap;
namespace content {
class NavigationEntryImpl;
+class RenderViewHost;
class WebContentsImpl;
class SiteInstance;
struct LoadCommittedDetails;
@@ -199,6 +200,12 @@ class CONTENT_EXPORT NavigationControllerImpl
void SetGetTimestampCallbackForTest(
const base::Callback<base::Time()>& get_timestamp_callback);
+ // Takes a screenshot of the page at the current state.
+ void TakeScreenshot();
+
+ void SetTakeScreenshotCallbackForTest(
+ const base::Callback<void(RenderViewHost*)>& take_screenshot_callback);
+
private:
friend class RestoreHelper;
friend class WebContentsImpl; // For invoking OnReservedPageIDRange.
@@ -312,9 +319,6 @@ class CONTENT_EXPORT NavigationControllerImpl
// specified |offset|. The index returned is not guaranteed to be valid.
int GetIndexForOffset(int offset) const;
- // Takes a screenshot of the page at the current state.
- void TakeScreenshot();
-
// The callback invoked when taking the screenshot of the page is complete.
// This sets the screenshot on the navigation entry.
void OnScreenshotTaken(int unique_id,
@@ -391,6 +395,10 @@ class CONTENT_EXPORT NavigationControllerImpl
// Used to get timestamps for newly-created navigation entries.
base::Callback<base::Time()> get_timestamp_callback_;
+ // A callback that gets called before taking the screenshot of the page. This
+ // is used only for testing.
+ base::Callback<void(RenderViewHost*)> take_screenshot_callback_;
+
// Used to smooth out timestamps from |get_timestamp_callback_|.
// Without this, whenever there is a run of redirects or
// code-generated navigations, those navigations may occur within
« no previous file with comments | « no previous file | content/browser/web_contents/navigation_controller_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698