overscroll: Take a screenshot at more appropriate times.

content/browser/web_contents/web_contents_view_aura_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_view_aura.h"
 
 #include "base/command_line.h"
 #include "base/run_loop.h"
 #include "base/test/test_timeouts.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/web_contents/navigation_controller_impl.h"
 #include "content/browser/web_contents/navigation_entry_impl.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/test_utils.h"
 #include "content/shell/shell.h"
 #include "content/test/content_browser_test.h"
 #include "content/test/content_browser_test_utils.h"
 #include "ui/aura/root_window.h"
 #include "ui/aura/test/event_generator.h"
 #include "ui/aura/window.h"
 
 namespace content {
 
+// A dummy callback to reset the screenshot-taker callback.
+void Dummy(RenderViewHost* host) {

[Charlie Reis, 2013/01/09 23:33:31]

nit: DummyCallback

[sadrul, 2013/01/09 23:37:58]

Done.

+}
+
+// This class keeps track of the RenderViewHost whose screenshot was captured.
+class ScreenshotTracker {
+ public:
+  explicit ScreenshotTracker(NavigationControllerImpl* controller)
+      : screenshot_taken_for_(NULL),
+        controller_(controller) {
+    controller_->SetTakeScreenshotCallbackForTest(
+        base::Bind(&ScreenshotTracker::TakeScreenshotCallback,
+                   base::Unretained(this)));
+  }
+
+  virtual ~ScreenshotTracker() {
+    controller_->SetTakeScreenshotCallbackForTest(
+        base::Bind(&Dummy));
+  }
+
+  RenderViewHost* screenshot_taken_for() { return screenshot_taken_for_; }
+
+  void Reset() {
+    screenshot_taken_for_ = NULL;
+  }
+
+ private:
+  void TakeScreenshotCallback(RenderViewHost* host) {
+    screenshot_taken_for_ = host;
+  }
+
+  RenderViewHost* screenshot_taken_for_;
+  NavigationControllerImpl* controller_;
+
+  DISALLOW_COPY_AND_ASSIGN(ScreenshotTracker);
+};
+
 class WebContentsViewAuraTest : public ContentBrowserTest {
  public:
   WebContentsViewAuraTest() {}
 
   virtual void SetUpCommandLine(CommandLine* command_line) {
     command_line->AppendSwitch(switches::kEnableOverscrollHistoryNavigation);
   }
 
   // Executes the javascript synchronously and makes sure the returned value is
   // freed properly.
@@ skipping 318 matching lines @@
     web_contents->GetController().GoBack();
     string16 actual_title = title_watcher.WaitAndGetTitle();
     EXPECT_EQ(expected_title, actual_title);
     EXPECT_EQ(3, GetCurrentIndex());
     entry = NavigationEntryImpl::FromNavigationEntry(
         web_contents->GetController().GetEntryAtIndex(4));
     EXPECT_TRUE(entry->screenshot().get());
   }
 }
 
+// Tests that screenshot is taken correct when navigation causes a

[Charlie Reis, 2013/01/09 23:33:31]

nit: correctly

[sadrul, 2013/01/09 23:37:58]

Done.

+// RenderViewHost to be swapped out.
+IN_PROC_BROWSER_TEST_F(WebContentsViewAuraTest,
+                       ScreenshotForSwappedOutRenderViews) {
+  ASSERT_NO_FATAL_FAILURE(
+      StartTestWithPage("files/overscroll_navigation.html"));
+  // Create a new server with a different site.
+  net::TestServer https_server(
+      net::TestServer::TYPE_HTTPS,
+      net::TestServer::kLocalhost,
+      FilePath(FILE_PATH_LITERAL("content/test/data")));
+  ASSERT_TRUE(https_server.Start());
+
+  WebContentsImpl* web_contents =
+      static_cast<WebContentsImpl*>(shell()->web_contents());
+
+  struct {
+    GURL url;
+    int transition;
+  } navigations[] = {
+    { https_server.GetURL("files/title1.html"),
+      PAGE_TRANSITION_TYPED | PAGE_TRANSITION_FROM_ADDRESS_BAR },
+    { test_server()->GetURL("files/title2.html"),
+      PAGE_TRANSITION_AUTO_BOOKMARK },
+    { https_server.GetURL("files/title3.html"),
+      PAGE_TRANSITION_TYPED | PAGE_TRANSITION_FROM_ADDRESS_BAR },
+    { GURL(), 0 }
+  };
+
+  ScreenshotTracker tracker(&web_contents->GetController());
+  for (int i = 0; !navigations[i].url.is_empty(); ++i) {
+    // Navigate via the user initiating a navigation from the UI.
+    NavigationController::LoadURLParams params(navigations[i].url);
+    params.transition_type = PageTransitionFromInt(navigations[i].transition);
+
+    RenderViewHost* old_host = web_contents->GetRenderViewHost();
+    web_contents->GetController().LoadURLWithParams(params);
+    WaitForLoadStop(web_contents);
+
+    EXPECT_NE(old_host, web_contents->GetRenderViewHost())
+        << navigations[i].url.spec();
+    EXPECT_EQ(old_host, tracker.screenshot_taken_for());
+    tracker.Reset();
+
+    NavigationEntryImpl* entry = NavigationEntryImpl::FromNavigationEntry(
+        web_contents->GetController().GetEntryAtOffset(-1));
+    EXPECT_TRUE(entry->screenshot().get());
+
+    entry = NavigationEntryImpl::FromNavigationEntry(
+        web_contents->GetController().GetActiveEntry());
+    EXPECT_FALSE(entry->screenshot().get());
+  }
+}
+
 }  // namespace content