scripts/slave/recipes/chromium_trybot.py - Issue 1177593002: Add swarming support for MB (and the GN bots) in the chromium recipes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot.py

Issue 1177593002: Add swarming support for MB (and the GN bots) in the chromium recipes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: updated baselines Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_Aura.json ('K') | « scripts/slave/recipes/chromium.expected/tsan.json ('k') | scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win8_chromium_ng.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_trybot.py

diff --git a/scripts/slave/recipes/chromium_trybot.py b/scripts/slave/recipes/chromium_trybot.py

index 3d25812f0adcf8d584390b2fbcc063434663eec5..b44be232e8c597bb07bd5af77dd666ff402ce13e 100644

--- a/scripts/slave/recipes/chromium_trybot.py

+++ b/scripts/slave/recipes/chromium_trybot.py

@@ -421,6 +421,13 @@ def _GenStepsInternal(api):

override_bot_type='builder_tester',

override_tests=tests)

+ if api.m.chromium.c.project_generator.tool == 'mb':

Paweł Hajdan Jr. 2015/06/10 10:27:19 Why is the MB logic duplicated inline between chro

Dirk Pranke 2015/06/10 16:11:40 The way we build swarming_targets is a bit differe

+ swarming_targets = [

+ t.name for t in tests_including_triggered if t.uses_swarming

+ ]

+ api.m.chromium.run_mb(mastername, buildername,

+ swarming_targets=swarming_targets)

requires_compile, _, compile_targets = \

api.chromium_tests.analyze(

affected_files,