Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(131)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1177563005: ServiceWorker: Implement ServiceWorkerRegistration.update() (3) (Closed)

Created:
4 years, 10 months ago by nhiroki
Modified:
4 years, 10 months ago
Reviewers:
falken
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@implement_update_1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

ServiceWorker: Implement ServiceWorkerRegistration.update() (3) Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-registration-update (1) Blink: https://codereview.chromium.org/1177913002/ (2) Chromium: https://codereview.chromium.org/1175823002/ (3) Blink: THIS PATCH BUG=450507 TEST=run-webkit-tests http/tests/serviceworker/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197130

Patch Set 1 : #

Total comments: 5

Patch Set 2 : incorporate falken@'s comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -0 lines) Patch
A LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/resources/update-worker.php View 1 1 chunk +35 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/update.html View 1 1 chunk +45 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/resources/update-worker.php View 1 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/update.html View 1 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
falken
lgtm https://codereview.chromium.org/1177563005/diff/20001/LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/resources/update-worker.php File LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/resources/update-worker.php (right): https://codereview.chromium.org/1177563005/diff/20001/LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/resources/update-worker.php#newcode4 LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/resources/update-worker.php:4: echo '// ' . microtime(); ah clever https://codereview.chromium.org/1177563005/diff/20001/LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/update.html ...
4 years, 10 months ago (2015-06-10 04:14:40 UTC) #3
nhiroki
Thank you for reviewing! I added "Cache-Control" header to update-worker.php in order to make sure ...
4 years, 10 months ago (2015-06-10 06:47:22 UTC) #4
falken
lgtm oops good catch with the lack of return in promise_test
4 years, 10 months ago (2015-06-12 05:56:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177563005/40001
4 years, 10 months ago (2015-06-15 17:00:10 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2015-06-15 17:59:39 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197130

Powered by Google App Engine
This is Rietveld 408576698