Generate metadata

Generate metadata

Fixes #198

BUG=https://github.com/dart-lang/dev_compiler/issues/198
R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/99d9a940966a191801589aa52215ba342aff1eae

[vsm, 2015-06-09 23:15:35]

vsm@google.com changed reviewers:
+ jmesserly@google.com

[Jennifer Messerly, 2015-06-09 23:29:53]

lgtm!

https://codereview.chromium.org/1177563003/diff/1/lib/runtime/dart/_intercept...
File lib/runtime/dart/_interceptors.js (right):

https://codereview.chromium.org/1177563003/diff/1/lib/runtime/dart/_intercept...
lib/runtime/dart/_interceptors.js:451: JSArray[dart.metadata] = () =>
[dart.const(new _js_helper.JsPeerInterface({name: 'Array'}))];
teach compiler we can skip our own private dart:_ annotations?

https://codereview.chromium.org/1177563003/diff/1/lib/src/codegen/js_codegen....
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1177563003/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:548: element, element.returnType,
node.constructorName, node.arguments, true);
./tool/format.sh ?  :)

https://codereview.chromium.org/1177563003/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:1766: _emitConstructorName(ConstructorElement
element, DartType type, SimpleIdentifier name) {
return type?

[vsm, 2015-06-10 13:28:27]

https://codereview.chromium.org/1177563003/diff/1/lib/runtime/dart/_intercept...
File lib/runtime/dart/_interceptors.js (right):

https://codereview.chromium.org/1177563003/diff/1/lib/runtime/dart/_intercept...
lib/runtime/dart/_interceptors.js:451: JSArray[dart.metadata] = () =>
[dart.const(new _js_helper.JsPeerInterface({name: 'Array'}))];
On 2015/06/09 23:29:53, John Messerly wrote:
> teach compiler we can skip our own private dart:_ annotations?

I'll file an issue for this.

https://codereview.chromium.org/1177563003/diff/1/lib/src/codegen/js_codegen....
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1177563003/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:548: element, element.returnType,
node.constructorName, node.arguments, true);
On 2015/06/09 23:29:53, John Messerly wrote:
> ./tool/format.sh ?  :)

Done.  Sorry - uploaded too early.

https://codereview.chromium.org/1177563003/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:1766: _emitConstructorName(ConstructorElement
element, DartType type, SimpleIdentifier name) {
On 2015/06/09 23:29:53, John Messerly wrote:
> return type?

Done.

[vsm, 2015-06-10 13:28:45]

Committed patchset #1 (id:1) manually as
99d9a940966a191801589aa52215ba342aff1eae (presubmit successful).