Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1177563002: SkyView should handle screen rotation (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Hixie, eseidel
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

SkyView should handle screen rotation This CL implements a basic version of screen rotation where we just relayout at the new size. In the future, we'll want a fancy version where we transition between the two layouts. R=ianh@google.com BUG= Committed: https://chromium.googlesource.com/external/mojo/+/0630a34a9962d6a950e3651a8c7fac637e772b16

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -12 lines) Patch
M sky/engine/core/view/View.h View 3 chunks +4 lines, -0 lines 0 comments Download
M sky/engine/core/view/View.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
M sky/engine/core/view/View.idl View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/lib/framework/app.dart View 1 2 chunks +10 lines, -4 lines 0 comments Download
M sky/sdk/lib/framework/rendering/box.dart View 1 1 chunk +16 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
abarth-chromium
5 years, 6 months ago (2015-06-09 20:23:33 UTC) #1
eseidel
lgtm
5 years, 6 months ago (2015-06-09 20:24:46 UTC) #3
Hixie
lgtm https://codereview.chromium.org/1177563002/diff/1/sky/sdk/lib/framework/app.dart File sky/sdk/lib/framework/app.dart (right): https://codereview.chromium.org/1177563002/diff/1/sky/sdk/lib/framework/app.dart#newcode62 sky/sdk/lib/framework/app.dart:62: _renderView.layout(_viewConstraints); I'm surprised this doesn't assert. We're not ...
5 years, 6 months ago (2015-06-09 20:31:31 UTC) #5
abarth-chromium
5 years, 6 months ago (2015-06-09 20:56:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0630a34a9962d6a950e3651a8c7fac637e772b16 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698