Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1177503005: [test] Fix test archive clobber. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Fix test archive clobber. The old version would always clobber. NOTRY=true NOTREECHECKS=true Committed: https://crrev.com/71bc7f8793adaf41047893ccc89560e8b0cf0b37 Cr-Commit-Position: refs/heads/master@{#28895}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M test/test262-es6/testcfg.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Michael Achenbach
PTAL
5 years, 6 months ago (2015-06-10 09:05:41 UTC) #2
Jakob Kummerow
lgtm
5 years, 6 months ago (2015-06-10 09:06:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177503005/1
5 years, 6 months ago (2015-06-10 09:07:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 09:08:55 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/71bc7f8793adaf41047893ccc89560e8b0cf0b37 Cr-Commit-Position: refs/heads/master@{#28895}
5 years, 6 months ago (2015-06-10 09:09:15 UTC) #7
arv (Not doing code reviews)
LGTM I just verified that the same code does not exist in test/test262/testcfg.py... which is ...
5 years, 6 months ago (2015-06-10 14:11:41 UTC) #8
Michael Achenbach
5 years, 6 months ago (2015-06-10 17:01:19 UTC) #9
Message was sent while issue was closed.
On 2015/06/10 14:11:41, arv wrote:
> LGTM
> 
> I just verified that the same code does not exist in
test/test262/testcfg.py...
> which is strange by itself.

Yes - I just added it to test262-es6 only. Wasn't entirely sure about the
effects. Should be added to test262, too.

Powered by Google App Engine
This is Rietveld 408576698