ui/views/controls/menu/menu_controller.cc - Issue 1177503003: Remove the 2-level input method system & InputMethodBridge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_controller.cc

Issue 1177503003: Remove the 2-level input method system & InputMethodBridge. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/views/controls/combobox/combobox_unittest.cc ('K') | « ui/views/controls/combobox/combobox_unittest.cc ('k') | ui/views/controls/menu/submenu_view.h » ('j') | ui/views/controls/prefix_selector.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/controls/menu/menu_controller.cc

diff --git a/ui/views/controls/menu/menu_controller.cc b/ui/views/controls/menu/menu_controller.cc

index 062c5f18aafe5565f2fb16b62970062fe7c81aab..54d3410bdd8508a9c8e34d20036bacfa330a401f 100644

--- a/ui/views/controls/menu/menu_controller.cc

+++ b/ui/views/controls/menu/menu_controller.cc

@@ -2078,7 +2078,7 @@ bool MenuController::SelectByChar(base::char16 character) {

return AcceptOrSelect(item, details);

if (is_combobox_) {

- item->GetSubmenu()->GetTextInputClient()->InsertChar(character, 0);

+ item->GetSubmenu()->GetPrefixSelector()->InsertChar(character, 0);

} else {

// If no mnemonics found, look at first character of titles.

details = FindChildForMnemonic(item, key, &TitleMatchesMnemonic);