ui/views/controls/combobox/combobox.h - Issue 1177503003: Remove the 2-level input method system & InputMethodBridge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/combobox/combobox.h

Issue 1177503003: Remove the 2-level input method system & InputMethodBridge. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased & removed views::View::GetTextInputClient & removed GetFocusedTextInputClient. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/views/cocoa/bridged_native_widget.mm ('K') | « ui/views/cocoa/bridged_native_widget.mm ('k') | ui/views/controls/combobox/combobox.cc » ('j') | ui/views/controls/combobox/combobox_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/controls/combobox/combobox.h

diff --git a/ui/views/controls/combobox/combobox.h b/ui/views/controls/combobox/combobox.h

index 4355504eb301d1d6b6f035b4fcd4b9202787a63e..1512dc11909225ae002dc5069730e4e063b8c01c 100644

--- a/ui/views/controls/combobox/combobox.h

+++ b/ui/views/controls/combobox/combobox.h

@@ -92,6 +92,8 @@ class VIEWS_EXPORT Combobox : public MenuDelegate,

void SetInvalid(bool invalid);

bool invalid() const { return invalid_; }

+ ui::TextInputClient* GetTextInputClient();

yukawa 2015/06/16 02:45:03 I prefer to use more descriptive name such as P

Shu Chen 2015/06/16 05:15:26 Done.

// Overridden from View:

gfx::Size GetPreferredSize() const override;

const char* GetClassName() const override;

@@ -102,7 +104,6 @@ class VIEWS_EXPORT Combobox : public MenuDelegate,

void OnFocus() override;

void OnBlur() override;

void GetAccessibleState(ui::AXViewState* state) override;

- ui::TextInputClient* GetTextInputClient() override;

void Layout() override;

// Overridden from MenuDelegate: