Remove the 2-level input method system & InputMethodBridge.

ui/views/cocoa/bridged_native_widget.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/views/cocoa/bridged_native_widget.h"
 
 #import <objc/runtime.h>
 
 #include "base/logging.h"
 #import "base/mac/foundation_util.h"
 #include "base/mac/mac_util.h"
 #import "base/mac/sdk_forward_declarations.h"
 #include "base/thread_task_runner_handle.h"
 #import "ui/base/cocoa/constrained_window/constrained_window_animation.h"
 #include "ui/base/hit_test.h"
 #include "ui/base/ime/input_method.h"
 #include "ui/base/ime/input_method_factory.h"
 #include "ui/base/ui_base_switches_util.h"
 #include "ui/gfx/display.h"
 #include "ui/gfx/geometry/dip_util.h"
 #import "ui/gfx/mac/coordinate_conversion.h"
 #import "ui/gfx/mac/nswindow_frame_controls.h"
 #include "ui/gfx/screen.h"
 #import "ui/views/cocoa/bridged_content_view.h"
 #import "ui/views/cocoa/cocoa_mouse_capture.h"
 #include "ui/views/cocoa/tooltip_manager_mac.h"
 #import "ui/views/cocoa/views_nswindow_delegate.h"
 #import "ui/views/cocoa/widget_owner_nswindow_adapter.h"
-#include "ui/views/ime/input_method_bridge.h"
-#include "ui/views/ime/null_input_method.h"
 #include "ui/views/view.h"
 #include "ui/views/views_delegate.h"
 #include "ui/views/widget/native_widget_mac.h"
 #include "ui/views/widget/widget.h"
 #include "ui/views/widget/widget_aura_utils.h"
 #include "ui/views/widget/widget_delegate.h"
 
 // The NSView that hosts the composited CALayer drawing the UI. It fills the
 // window but is not hittable so that accessibility hit tests always go to the
 // BridgedContentView.
@@ skipping 660 matching lines @@
   bool shows_resize_controls =
       is_resizable && (min_size.IsEmpty() || min_size != max_size);
   bool shows_fullscreen_controls =
       is_resizable && widget->widget_delegate()->CanMaximize();
 
   gfx::ApplyNSWindowSizeConstraints(window_, min_size, max_size,
                                     shows_resize_controls,
                                     shows_fullscreen_controls);
 }
 
-InputMethod* BridgedNativeWidget::CreateInputMethod() {
-  if (switches::IsTextInputFocusManagerEnabled())
-    return new NullInputMethod();
-
-  return new InputMethodBridge(this, GetHostInputMethod(), true);
-}
-
-ui::InputMethod* BridgedNativeWidget::GetHostInputMethod() {
+ui::InputMethod* BridgedNativeWidget::GetInputMethod() {
   if (!input_method_) {
     // Delegate is NULL because Mac IME does not need DispatchKeyEventPostIME
     // callbacks.
     input_method_ = ui::CreateInputMethod(NULL, nil);

[yukawa, 2015/06/11 21:48:42]

Well if we almost always need to call |OnFocus()| just after CreateInputMethod,
can we modify CreateInputMethod instead?

Option 1.
    UI_BASE_IME_EXPORT scoped_ptr<InputMethod> CreateInputMethod(
        internal::InputMethodDelegate* delegate,
        gfx::AcceleratedWidget widget,
        bool has_initial_focus);

Option 2.
    UI_BASE_IME_EXPORT scoped_ptr<InputMethod> CreateInputMethodAndFocus(
        internal::InputMethodDelegate* delegate,
        gfx::AcceleratedWidget widget);

We should be able to do that in a separate CL.

[Shu Chen, 2015/06/12 03:34:38]

I will do a CL soon to avoid such default-focused behavior.
I put OnFocus() call here to fix some test failures.
Because some tests deal with views::InputMethod which doesn't have
"toplevel_focused" state.
Now they deal with ui::InputMethod which is sensitive about its
"toplevel_focused" state.

+    input_method_->OnFocus();
   }
   return input_method_.get();
 }
 
 gfx::Rect BridgedNativeWidget::GetRestoredBounds() const {
   if (target_fullscreen_state_ || in_fullscreen_transition_)
     return bounds_before_fullscreen_;
 
   return gfx::ScreenRectFromNSRect([window_ frame]);
 }
@@ skipping 19 matching lines @@
   layer()->SetFillsBoundsOpaquely(!translucent);
   if (translucent) {
     [window_ setOpaque:NO];
     [window_ setBackgroundColor:[NSColor clearColor]];
   }
 
   UpdateLayerProperties();
 }
 
 ////////////////////////////////////////////////////////////////////////////////
-// BridgedNativeWidget, internal::InputMethodDelegate:
-
-void BridgedNativeWidget::DispatchKeyEventPostIME(const ui::KeyEvent& key) {
-  DCHECK(focus_manager_);
-  native_widget_mac_->GetWidget()->OnKeyEvent(const_cast<ui::KeyEvent*>(&key));
-  if (!key.handled())
-    focus_manager_->OnKeyEvent(key);
-}
-
-////////////////////////////////////////////////////////////////////////////////
 // BridgedNativeWidget, CocoaMouseCaptureDelegate:
 
 void BridgedNativeWidget::PostCapturedEvent(NSEvent* event) {
   [bridged_view_ processCapturedMouseEvent:event];
 }
 
 void BridgedNativeWidget::OnMouseCaptureLost() {
   native_widget_mac_->GetWidget()->OnMouseCaptureLost();
 }
 
@@ skipping 247 matching lines @@
   [bridged_view_ setMouseDownCanMoveWindow:draggable];
   // AppKit will not update its cache of mouseDownCanMoveWindow unless something
   // changes. Previously we tried adding an NSView and removing it, but for some
   // reason it required reposting the mouse-down event, and didn't always work.
   // Calling the below seems to be an effective solution.
   [window_ setMovableByWindowBackground:NO];
   [window_ setMovableByWindowBackground:YES];
 }
 
 }  // namespace views