ui/base/ime/mock_input_method.h - Issue 1177503003: Remove the 2-level input method system & InputMethodBridge.

Side by Side Diff: ui/base/ime/mock_input_method.h

Issue 1177503003: Remove the 2-level input method system & InputMethodBridge. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: makes trybots green. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ui/base/ime/input_method_factory.cc ('k') | ui/base/ime/mock_input_method.cc » ('j') | ui/views/cocoa/bridged_native_widget.mm » ('J')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef UI_BASE_IME_MOCK_INPUT_METHOD_H_	5 #ifndef UI_BASE_IME_MOCK_INPUT_METHOD_H_

6 #define UI_BASE_IME_MOCK_INPUT_METHOD_H_	6 #define UI_BASE_IME_MOCK_INPUT_METHOD_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 #include "base/basictypes.h"	10 #include "base/basictypes.h"

(...skipping 39 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
50 int GetTextInputFlags() const override;	50 int GetTextInputFlags() const override;

51 bool CanComposeInline() const override;	51 bool CanComposeInline() const override;

52 bool IsCandidatePopupOpen() const override;	52 bool IsCandidatePopupOpen() const override;

53 void ShowImeIfNeeded() override;	53 void ShowImeIfNeeded() override;

54 void AddObserver(InputMethodObserver* observer) override;	54 void AddObserver(InputMethodObserver* observer) override;

55 void RemoveObserver(InputMethodObserver* observer) override;	55 void RemoveObserver(InputMethodObserver* observer) override;

56	56

57 private:	57 private:

58 TextInputClient* text_input_client_;	58 TextInputClient* text_input_client_;

59 base::ObserverList<InputMethodObserver> observer_list_;	59 base::ObserverList<InputMethodObserver> observer_list_;

	60 internal::InputMethodDelegate* delegate_;
	yukawa 2015/06/11 21:48:42 Can we split changes in mock_input_method.{h, cc} Can we split changes in mock_input_method.{h, cc} into a separate CL? Shu Chen 2015/06/12 03:34:38 I recall this is to fix some test failures. MockIn Show quoted text On 2015/06/11 21:48:42, yukawa wrote: > Can we split changes in mock_input_method.{h, cc} into a separate CL? I recall this is to fix some test failures. MockInputMethod::DispatchKeyEvent mutes all key events, which is wrong. Instead, it should release key events by calling DispatchKeyEventPostIME. yukawa 2015/06/12 05:20:45 Would it be possible to commit changes in mock_inp Show quoted text On 2015/06/12 03:34:38, Shu Chen wrote: > On 2015/06/11 21:48:42, yukawa wrote: > > Can we split changes in mock_input_method.{h, cc} into a separate CL? > > I recall this is to fix some test failures. MockInputMethod::DispatchKeyEvent > mutes all key events, which is wrong. Instead, it should release key events by > calling DispatchKeyEventPostIME. Would it be possible to commit changes in mock_input_method.{h, cc} before this CL? I'd like to keep the size of this CL as small as possible. Shu Chen 2015/06/12 05:32:54 No problem. I've reverted the changes for MockInpu Show quoted text On 2015/06/12 05:20:45, yukawa wrote: > On 2015/06/12 03:34:38, Shu Chen wrote: > > On 2015/06/11 21:48:42, yukawa wrote: > > > Can we split changes in mock_input_method.{h, cc} into a separate CL? > > > > I recall this is to fix some test failures. MockInputMethod::DispatchKeyEvent > > mutes all key events, which is wrong. Instead, it should release key events by > > calling DispatchKeyEventPostIME. > > Would it be possible to commit changes in mock_input_method.{h, cc} before this > CL? I'd like to keep the size of this CL as small as possible. No problem. I've reverted the changes for MockInputMethod in this cl. And I will create another cl for it soon.
60	61

61 DISALLOW_COPY_AND_ASSIGN(MockInputMethod);	62 DISALLOW_COPY_AND_ASSIGN(MockInputMethod);

62 };	63 };

63	64

64 } // namespace ui	65 } // namespace ui

65	66

66 #endif // UI_BASE_IME_MOCK_INPUT_METHOD_H_	67 #endif // UI_BASE_IME_MOCK_INPUT_METHOD_H_

OLD	NEW