Media Documents should disable View [Page] Source

content/browser/web_contents/navigation_controller_impl.cc

Index: content/browser/web_contents/navigation_controller_impl.cc
diff --git a/content/browser/web_contents/navigation_controller_impl.cc b/content/browser/web_contents/navigation_controller_impl.cc
index bd6971646b8d428103ed5fcb13eb1b9d226ebf1e..3da41144905a0d960b32d172d95987a112c567ff 100644
--- a/content/browser/web_contents/navigation_controller_impl.cc
+++ b/content/browser/web_contents/navigation_controller_impl.cc
@@ -442,11 +442,12 @@ NavigationEntry* NavigationControllerImpl::GetLastCommittedEntry() const {
 }
 
 bool NavigationControllerImpl::CanViewSource() const {
-  bool is_supported_mime_type = net::IsSupportedNonImageMimeType(
-      web_contents_->GetContentsMimeType().c_str());
+  const std::string& mime_type = web_contents_->GetContentsMimeType().c_str();
+  bool is_viewable_mime_type = net::IsSupportedNonImageMimeType(mime_type) &&
+      !net::IsSupportedMediaMimeType(mime_type);

[scherkus (not reviewing), 2013/01/07 17:07:44]

as a general FYI the one thing to sanity check here is that the list of
supported media mime types here is the same as the list that's used to trigger
the display of media (aka MediaDocument), otherwise we could end up in a
situation where (for example) we trigger a MediaDocument but we still have view
source enabled.

I believe we're good here since the code that triggers MediaDocument based on
MIME type...

https://code.google.com/searchframe#OAMlx_jo-ck/src/third_party/WebKit/Source...

... ends up checking the same function:

https://code.google.com/searchframe#OAMlx_jo-ck/src/webkit/glue/simple_webmim...

[wolenetz, 2013/01/07 19:28:26]

Scherkus & I synced offline, and agree that risk of media mime_type support
divergence exists.  However, the net code is where we would change the set of
supported media types, so risk is mitigated somewhat.  We will also avoid
possible layering violation and continue with the current approach of calling
the net function directly.

   NavigationEntry* active_entry = GetActiveEntry();
   return active_entry && !active_entry->IsViewSourceMode() &&
-    is_supported_mime_type && !web_contents_->GetInterstitialPage();
+    is_viewable_mime_type && !web_contents_->GetInterstitialPage();

[scherkus (not reviewing), 2013/01/07 17:07:44]

nit: this should have been a 4 space indent

[wolenetz, 2013/01/07 19:28:26]

Thanks.  Fixed, I will upload another PS.

 }
 
 int NavigationControllerImpl::GetLastCommittedEntryIndex() const {