Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1177483003: Revert of Change focus status according to the change of window focus (Closed)

Created:
5 years, 6 months ago by Jaekyun Seok (inactive)
Modified:
5 years, 6 months ago
Reviewers:
Ted C, jdduke (slow), AKVT, boliu
CC:
chromium-reviews, darin-cc_chromium.org, jam, AKVT
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change focus status according to the change of window focus (patchset #5 id:80001 of https://codereview.chromium.org/1164033002/) Reason for revert: This CL caused http://crbug.com/498631. Original issue's description: > Change focus status according to the change of window focus > > On Android, View's focus status isn't changed when window focus is lost. > So we should update ContentViewCore's focus status according to the > change of window focus. > > BUG=495547 > > Committed: https://crrev.com/98d5087ecd03ed36ec2e161102b71dad97a92b4c > Cr-Commit-Position: refs/heads/master@{#333446} TBR=jdduke@chromium.org,tedchoc@chromium.org,boliu@chromium.org,ajith.v@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=495547 Committed: https://crrev.com/aab0a28a16e614146aed8d5bc62d9784f13ff93c Cr-Commit-Position: refs/heads/master@{#333784}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -17 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 3 chunks +3 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jaekyun Seok (inactive)
Created Revert of Change focus status according to the change of window focus
5 years, 6 months ago (2015-06-10 20:18:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177483003/1
5 years, 6 months ago (2015-06-10 20:18:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 20:19:39 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 20:20:37 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aab0a28a16e614146aed8d5bc62d9784f13ff93c
Cr-Commit-Position: refs/heads/master@{#333784}

Powered by Google App Engine
This is Rietveld 408576698