Migrate more functions from MathUtil to gfx::Transform

ui/gfx/transform.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // MSVC++ requires this to be set before any other includes to get M_PI.
 #define _USE_MATH_DEFINES
 
 #include "ui/gfx/transform.h"
 
 #include <cmath>
@@ skipping 14 matching lines @@
 // Taken from SkMatrix44.
 const double kTooSmallForDeterminant = 1e-8;
 
 double TanDegrees(double degrees) {
   double radians = degrees * M_PI / 180;
   return std::tan(radians);
 }
 
 }  // namespace
 
+Transform::Transform(
+    double col1row1, double col2row1, double col3row1, double col4row1,
+    double col1row2, double col2row2, double col3row2, double col4row2,
+    double col1row3, double col2row3, double col3row3, double col4row3,
+    double col1row4, double col2row4, double col3row4, double col4row4)
+    : matrix_(SkMatrix44::kUninitialized_Constructor)
+{
+  // Initialize column 1

[danakj, 2013/01/11 04:14:12]

nit: i dont think these comments are explaining much

+  matrix_.setDouble(0, 0, col1row1);
+  matrix_.setDouble(1, 0, col1row2);
+  matrix_.setDouble(2, 0, col1row3);
+  matrix_.setDouble(3, 0, col1row4);
+
+  // Initialize column 2
+  matrix_.setDouble(0, 1, col2row1);
+  matrix_.setDouble(1, 1, col2row2);
+  matrix_.setDouble(2, 1, col2row3);
+  matrix_.setDouble(3, 1, col2row4);
+
+  // Initialize column 3
+  matrix_.setDouble(0, 2, col3row1);
+  matrix_.setDouble(1, 2, col3row2);
+  matrix_.setDouble(2, 2, col3row3);
+  matrix_.setDouble(3, 2, col3row4);
+
+  // Initialize column 4
+  matrix_.setDouble(0, 3, col4row1);
+  matrix_.setDouble(1, 3, col4row2);
+  matrix_.setDouble(2, 3, col4row3);
+  matrix_.setDouble(3, 3, col4row4);
+}
+
+Transform::Transform(
+    double col1row1, double col2row1,
+    double col1row2, double col2row2,
+    double x_translation, double y_translation)

[danakj, 2013/01/11 04:14:12]

can you make this call matrix_(SkMatrix44::kIdentity_Constructor) explicitly?

+{
+  matrix_.setDouble(0, 0, col1row1);
+  matrix_.setDouble(1, 0, col1row2);
+  matrix_.setDouble(0, 1, col2row1);
+  matrix_.setDouble(1, 1, col2row2);
+  matrix_.setDouble(0, 3, x_translation);
+  matrix_.setDouble(1, 3, y_translation);
+}
+
 void Transform::RotateAboutXAxis(double degrees) {
   double radians = degrees * M_PI / 180;
   double cosTheta = std::cos(radians);
   double sinTheta = std::sin(radians);
   if (matrix_.isIdentity()) {
       matrix_.set3x3(1, 0, 0,
                      0, cosTheta, sinTheta,
                      0, -sinTheta, cosTheta);
   } else {
     SkMatrix44 rot;
@@ skipping 207 matching lines @@
     return false;
   }
 
   return true;
 }
 
 void Transform::Transpose() {
   matrix_.transpose();
 }
 
+void Transform::FlattenTo2d() {
+  matrix_.setDouble(2, 0, 0.0);
+  matrix_.setDouble(2, 1, 0.0);
+  matrix_.setDouble(0, 2, 0.0);
+  matrix_.setDouble(1, 2, 0.0);
+  matrix_.setDouble(2, 2, 1.0);
+  matrix_.setDouble(3, 2, 0.0);
+  matrix_.setDouble(2, 3, 0.0);
+}
+
 void Transform::TransformPoint(Point& point) const {
   TransformPointInternal(matrix_, point);
 }
 
 void Transform::TransformPoint(Point3F& point) const {
   TransformPointInternal(matrix_, point);
 }
 
 bool Transform::TransformPointReverse(Point& point) const {
   // TODO(sad): Try to avoid trying to invert the matrix.
@@ skipping 118 matching lines @@
       matrix_.getDouble(2, 1),
       matrix_.getDouble(2, 2),
       matrix_.getDouble(2, 3),
       matrix_.getDouble(3, 0),
       matrix_.getDouble(3, 1),
       matrix_.getDouble(3, 2),
       matrix_.getDouble(3, 3));
 }
 
 }  // namespace gfx