Issue 11774002: [Telemetry] Teach telemetry to recognize beta and dev chrome on android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11774002: [Telemetry] Teach telemetry to recognize beta and dev chrome on android. (Closed)

Created:
7 years, 11 months ago by tonyg

Modified:
7 years, 11 months ago

Reviewers:
dtu, nduca

CC:
chromium-reviews, chrome-speed-team+watch_google.com, pam+watch_chromium.org, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Telemetry] Teach telemetry to recognize beta and dev chrome on android. BUG=168292 TEST=tools/perf/run_multipage_benchmarks --browser=android-chrome-dev spaceport tools/perf/page_sets/spaceport.json Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175199

Patch Set 1 #

Total comments: 1

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -28 lines)			Patch
	M	tools/telemetry/telemetry/android_browser_finder.py	View		2 chunks	+20 lines, -28 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nduca

lgtm https://codereview.chromium.org/11774002/diff/1/tools/telemetry/telemetry/android_browser_finder.py File tools/telemetry/telemetry/android_browser_finder.py (right): https://codereview.chromium.org/11774002/diff/1/tools/telemetry/telemetry/android_browser_finder.py#newcode27 tools/telemetry/telemetry/android_browser_finder.py:27: CHROME_ACTIVITY = 'com.google.android.apps.chrome.Main' just out of curiosity, do ...

7 years, 11 months ago (2013-01-04 19:47:08 UTC) #2

tonyg

7 years, 11 months ago (2013-01-04 21:48:46 UTC) #3

On 2013/01/04 19:47:08, nduca wrote:
> lgtm
> 
>
https://codereview.chromium.org/11774002/diff/1/tools/telemetry/telemetry/and...
> File tools/telemetry/telemetry/android_browser_finder.py (right):
> 
>
https://codereview.chromium.org/11774002/diff/1/tools/telemetry/telemetry/and...
> tools/telemetry/telemetry/android_browser_finder.py:27: CHROME_ACTIVITY =
> 'com.google.android.apps.chrome.Main'
> just out of curiosity, do we have code somewhere that somehow makes sure this
> activity is sent to the right app when a device has both chrome and
chrome-beta?

Yes, the package name does that.

Expand Messages | Collapse Messages