Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1177383004: Also handle elements in *RealNamed* api methods (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Also handle elements in *RealNamed* api methods Apparently the *RealNamed* API methods only have named variants, but were always used by the embedder to find elements as well. We'd never find them though, since we wouldn't even look there. This CL ensures we check whether the name is actually an array index. I guess for all named API functions we should assume they are used similar to o["name"] where name could also be a number... At least we should make it uniform between embedder and V8. This matches us up with their expectations for now... BUG=v8:4137 LOG=n Committed: https://crrev.com/028025f07e26ee7f962ff0a1ab9362868e58bac9 Cr-Commit-Position: refs/heads/master@{#29008}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M src/api.cc View 1 4 chunks +12 lines, -8 lines 0 comments Download
M src/objects.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jakob Kummerow
LGTM
5 years, 6 months ago (2015-06-13 10:25:56 UTC) #2
Jakob Kummerow
Still LGTM
5 years, 6 months ago (2015-06-13 10:31:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177383004/20001
5 years, 6 months ago (2015-06-13 10:32:14 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-13 11:16:06 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-13 11:16:19 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/028025f07e26ee7f962ff0a1ab9362868e58bac9
Cr-Commit-Position: refs/heads/master@{#29008}

Powered by Google App Engine
This is Rietveld 408576698