Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1063)

Unified Diff: Source/core/page/FocusController.h

Issue 1177373002: Change API name and return type of findFocusableNode (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: *recursively Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/input/EventHandler.cpp ('k') | Source/core/page/FocusController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/FocusController.h
diff --git a/Source/core/page/FocusController.h b/Source/core/page/FocusController.h
index d2fc08fd98862f475af4d5f5754f954bc639365e..98ad6518522b7966719c13326e76a7b5ebd44559 100644
--- a/Source/core/page/FocusController.h
+++ b/Source/core/page/FocusController.h
@@ -58,7 +58,7 @@ public:
bool setInitialFocus(WebFocusType);
bool advanceFocus(WebFocusType type) { return advanceFocus(type, false); }
- Node* findFocusableNode(WebFocusType, Node&);
+ Element* findFocusableElement(WebFocusType, Node&);
bool setFocusedElement(Element*, PassRefPtrWillBeRawPtr<Frame>, WebFocusType = WebFocusTypeNone);
@@ -81,9 +81,9 @@ private:
Node* findFocusableNodeAcrossFocusScopesForward(const FocusNavigationScope&, Node*);
Node* findFocusableNodeAcrossFocusScopesBackward(const FocusNavigationScope&, Node*);
- Node* findFocusableNodeRecursively(WebFocusType, const FocusNavigationScope&, Node*);
- Node* findFocusableNodeRecursivelyForward(const FocusNavigationScope&, Node*);
- Node* findFocusableNodeRecursivelyBackward(const FocusNavigationScope&, Node*);
+ Element* findFocusableElementRecursively(WebFocusType, const FocusNavigationScope&, Node*);
+ Element* findFocusableElementRecursivelyForward(const FocusNavigationScope&, Node*);
+ Element* findFocusableElementRecursivelyBackward(const FocusNavigationScope&, Node*);
Node* findFocusableNodeDecendingDownIntoFrameDocument(WebFocusType, Node*);
@@ -100,7 +100,7 @@ private:
//
// [1] https://html.spec.whatwg.org/multipage/interaction.html#sequential-focus-navigation
// [2] https://w3c.github.io/webcomponents/spec/shadow/#focus-navigation
- inline Node* findFocusableNode(WebFocusType, const FocusNavigationScope&, Node* start);
+ inline Element* findFocusableElement(WebFocusType, const FocusNavigationScope&, Node* start);
bool advanceFocusDirectionallyInContainer(Node* container, const LayoutRect& startingRect, WebFocusType);
void findFocusCandidateInContainer(Node& container, const LayoutRect& startingRect, WebFocusType, FocusCandidate& closest);
« no previous file with comments | « Source/core/input/EventHandler.cpp ('k') | Source/core/page/FocusController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698