Issue 1177373002: Change API name and return type of findFocusableNode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1177373002: Change API name and return type of findFocusableNode (Closed)

Created:
4 years, 10 months ago by kochi

Modified:
4 years, 10 months ago

Reviewers:
hayato

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/remotes/origin/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Change API name and return type of findFocusableNode This renames FocusController::findFocusableNode() to findFocusableElement(), and return Element instead of Node. This is a part of code cleanup that focused node should be Element. Further clean up inside FocusController will follow. BUG=499667 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197004

Patch Set 1 #

Patch Set 2 : *recursively #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -43 lines)			Patch
M	Source/core/dom/Element.cpp	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/input/EventHandler.cpp	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/page/FocusController.h	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/core/page/FocusController.cpp	View	1	10 chunks	+36 lines, -32 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1177373002/20001

4 years, 10 months ago (2015-06-12 04:55:27 UTC) #5

commit-bot: I haz the power

4 years, 10 months ago (2015-06-12 06:14:27 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197004

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages